[ML] Add SageMaker #4940
Draft
[ML] Add SageMaker #4940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create put request types, objects, and examples for SageMaker. Verified with `make validate api=inference.put`.
prwhelan
commented
Jul 16, 2025
| /** | ||
| * Service Settings specific to the Elastic API for the Amazon SageMaker service. | ||
| */ | ||
| export class AmazonSageMakerElasticServiceSettings extends AmazonSageMakerServiceSettings { |
There was a problem hiding this comment.
Let me know if I should delete this and roll it into the parent class - I don't see a lot of inheritance going on (and that's maybe a good thing) but it might look weird for TaskSettings because elastic can handle any input key/value pair
|
Following you can find the validation changes against the target branch for the API.
You can validate this API yourself by using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create put request types, objects, and examples for SageMaker. Verified with
make validate api=inference.put.