allowed test IP values do not match ingest geoip how to IP values

[efd6]

There is mismatch between https://github.com/elastic/elastic-package/blob/main/internal/fields/_static/allowed_geo_ips.txt and https://github.com/elastic/elastic-package/blob/main/docs/howto/ingest_geoip.md.

These should match to avoid confusion.

[jsoriano]

Yes, this mismatch is expected.

The list in allowed_geoips.txt is maintained mainly for backwards compatibility with packages that are using them for testing. Links to this file were removed from documentation.

Currently users should use what is mentioned in the documentation: https://github.com/elastic/elastic-package/blob/main/docs/howto/ingest_geoip.md

In the future we may remove support for the ips in allowed_geoips.txt. Till then, these lists are going to be necessarily different.

[efd6]

I don't think this should be closed. If there is an expected mismatch, that should be noted in the documentation.

[jsoriano]

How would we note this in the documentation? Maybe mentioning that some additional IPs are allowed for backwards compatibility? Adding something like this to https://github.com/elastic/elastic-package/blob/main/docs/howto/ingest_geoip.md?

Some additional IP ranges are allowed for backwards compatibility reasons, but they should not be used in new test files.

[efd6]

Yeah, something like that, with a link between the two documents for discoverability. And the advice given by the tool should be the better advice, not the backward compatibility advice.

[jsoriano]

between the two documents for discoverability

allowed_geo_ips.txt at this point is code, not documentation. Is it referenced from some documentation site? If it is we should remove these references.

If this file is confusing we could remove it and bring these IP ranges to the Go code.

And the advice given by the tool should be the better advice, not the backward compatibility advice.

This is what current documentation does, it encourages to use the IPs in the documented ranges.

Happy to review a PR if you have suggestions on how to improve the situation.

[efd6]

allowed_geo_ips.txt at this point is code, not documentation. Is it referenced from some documentation site? If it is we should remove these references.

elastic-package emits it as an error. This makes it documentation.

[0] the IP "1.1.1.1" is not one of the allowed test IPs (see: https://github.com/elastic/elastic-package/blob/main/internal/fields/_static/allowed_geo_ips.txt)

And the advice given by the tool should be the better advice, not the backward compatibility advice.

This is what current documentation does, it encourages to use the IPs in the documented ranges.

Can I clarify which of the two is the better advice? I assumed the document at https://github.com/elastic/elastic-package/blob/main/docs/howto/ingest_geoip.md is the better advice. If that's the case, then the link in the error should be pointing to that.

[jsoriano]

Oh ok, I understand the confusion now. This is definitely outdated, fixing in #2853. Thanks!