Skip to content

Commit a17fcdd

Browse files
committed
Add variant for Kibana >= 8.7.0 with Fleet experimental toggles enabled (#1128)
1 parent d400e9d commit a17fcdd

File tree

5 files changed

+26
-11
lines changed

5 files changed

+26
-11
lines changed

.ci/Jenkinsfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ pipeline {
9999
'stack-command-default': generateTestCommandStage(command: 'test-stack-command-default', artifacts: ['build/elastic-stack-dump/stack/*/logs/*.log', 'build/elastic-stack-dump/stack/*/logs/fleet-server-internal/*', 'build/elastic-stack-status/*/*']),
100100
'stack-command-oldest': generateTestCommandStage(command: 'test-stack-command-oldest', artifacts: ['build/elastic-stack-dump/stack/*/logs/*.log', 'build/elastic-stack-dump/stack/*/logs/fleet-server-internal/*', 'build/elastic-stack-status/*/*']),
101101
'stack-command-7x': generateTestCommandStage(command: 'test-stack-command-7x', artifacts: ['build/elastic-stack-dump/stack/*/logs/*.log', 'build/elastic-stack-dump/stack/*/logs/fleet-server-internal/*', 'build/elastic-stack-status/*/*']),
102+
'stack-command-86': generateTestCommandStage(command: 'test-stack-command-86', artifacts: ['build/elastic-stack-dump/stack/*/logs/*.log', 'build/elastic-stack-dump/stack/*/logs/fleet-server-internal/*', 'build/elastic-stack-status/*/*']),
102103
'stack-command-8x': generateTestCommandStage(command: 'test-stack-command-8x', artifacts: ['build/elastic-stack-dump/stack/*/logs/*.log', 'build/elastic-stack-dump/stack/*/logs/fleet-server-internal/*', 'build/elastic-stack-status/*/*']),
103104
'check-packages-with-kind': generateTestCommandStage(command: 'test-check-packages-with-kind', artifacts: ['build/test-results/*.xml', 'build/kubectl-dump.txt', 'build/elastic-stack-dump/check-*/logs/*.log', 'build/elastic-stack-dump/check-*/logs/fleet-server-internal/*'], junitArtifacts: true, publishCoverage: true),
104105
'check-packages-other': generateTestCommandStage(command: 'test-check-packages-other', artifacts: ['build/test-results/*.xml', 'build/elastic-stack-dump/check-*/logs/*.log', 'build/elastic-stack-dump/check-*/logs/fleet-server-internal/*'], junitArtifacts: true, publishCoverage: true),

Makefile

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,14 @@ test-stack-command-oldest:
5858
./scripts/test-stack-command.sh 7.14.2
5959

6060
test-stack-command-7x:
61-
./scripts/test-stack-command.sh 7.17.3-SNAPSHOT
61+
./scripts/test-stack-command.sh 7.17.8
62+
63+
# Keeping a test for 8.6 because it has an specific configuration file.
64+
test-stack-command-86:
65+
./scripts/test-stack-command.sh 8.6.1
6266

6367
test-stack-command-8x:
64-
./scripts/test-stack-command.sh 8.6.0-SNAPSHOT
68+
./scripts/test-stack-command.sh 8.7.0-SNAPSHOT
6569

6670
test-stack-command: test-stack-command-default test-stack-command-7x test-stack-command-800 test-stack-command-8x
6771

internal/stack/_static/kibana.yml.tmpl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ xpack.fleet.registryUrl: "https://package-registry:8080"
2828
xpack.fleet.agents.enabled: true
2929
xpack.fleet.agents.fleet_server.hosts: ["https://fleet-server:8220"]
3030

31+
{{ if not (semverLessThan $version "8.7.0") }}
32+
xpack.fleet.enableExperimental: ["experimentalDataStreamSettings"] # Enable experimental toggles in Fleet UI
33+
{{ end }}
34+
3135
xpack.encryptedSavedObjects.encryptionKey: "12345678901234567890123456789012"
3236

3337
{{ if not (semverLessThan $version "8.1.0") }}

internal/stack/variants.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,15 @@ import (
1414
// This map is used to deploy different versions of the Elastic stack with matching configurations.
1515
var configurationVariantMap = map[string]string{
1616
"8.0-0 - 8.1.x-x": "80",
17-
"^8.2-0": "8x",
17+
"8.2-0 - 8.6.x-x": "86",
18+
"^8.7-0": "8x",
1819
}
1920

2021
// stackVariantAsEnv function returns a stack variant based on the given stack version.
2122
// We identified three variants:
2223
// * default, covers all of 7.x branches
2324
// * 80, covers stack versions 8.0.0 to 8.1.x
25+
// * 86, covers stack versions 8.2.0 to 8.6.x, they don't support experimental toggles in Fleet
2426
// * 8x, supports different configuration options in Kibana, covers stack versions 8.2.0+
2527
func stackVariantAsEnv(version string) string {
2628
return fmt.Sprintf("STACK_VERSION_VARIANT=%s", selectStackVersion(version))

internal/stack/variants_test.go

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,18 @@ var tests = []struct {
3232
{"8.1.58", "80"},
3333
{"8.1.99-beta", "80"},
3434
{"8.1.999-SNAPSHOT", "80"},
35-
{"8.2-0", "8x"},
36-
{"8.2", "8x"},
37-
{"8.2.0-alpha", "8x"},
38-
{"8.2.0", "8x"},
39-
{"8.2.58", "8x"},
40-
{"8.2.99-gamma", "8x"},
41-
{"8.2.777-SNAPSHOT+arm64", "8x"},
42-
{"8.5", "8x"},
35+
{"8.2-0", "86"},
36+
{"8.2", "86"},
37+
{"8.2.0-alpha", "86"},
38+
{"8.2.0", "86"},
39+
{"8.2.58", "86"},
40+
{"8.2.99-gamma", "86"},
41+
{"8.2.777-SNAPSHOT+arm64", "86"},
42+
{"8.5", "86"},
43+
{"8.6.1", "86"},
44+
{"8.7.0", "8x"},
45+
{"8.7.0-SNAPSHOT", "8x"},
46+
{"8.7.1-SNAPSHOT", "8x"},
4347
{"9", "default"},
4448
}
4549

0 commit comments

Comments
 (0)