Set persistentVolumeClaimRetentionPolicy per default delete #8918 #8920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test ECK against OCP 4.20.4 in order to be able to declare that we are compatible. Signed-off-by: Lars Barmettler <[email protected]>
Signed-off-by: Lars Barmettler <[email protected]>
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
barkbay
reviewed
Nov 25, 2025
| {{- include "eck-operator.selectorLabels" . | nindent 6 }} | ||
| serviceName: {{ include "eck-operator.fullname" . }} | ||
| replicas: {{ .Values.replicaCount }} | ||
| persistentVolumeClaimRetentionPolicy: |
Contributor
There was a problem hiding this comment.
The operator has no volumeClaimTemplates, so I'm a bit unsure about the purpose of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change I want to make sure that the PVC getting deleted once the StatefulSet is deleted or scaled down. In the context of our Organisation, we'd like to have a policy in place that enfoces persistentVolumeClaimRetentionPolicy to be set. More information about persistentVolumeClaimRetentionPolicy you can find under https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#persistentvolumeclaim-retention.
I think having whenDeleted and whenScaled with the Delete option is the most sensible choice, since how I understood it the eck-operator does not take usage of the persistence property we would get if we have the Retain option.
I've saw that #8478 already mentioned this issue.
signed agreement
Complete_with_Docusign_Elastic_Contributor_L.pdf