Skip to content

Commit bf72b9d

Browse files
committed
Change variable name in the correct function
1 parent 42ad37d commit bf72b9d

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

internal/release/executionspace.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,23 +25,23 @@ import (
2525
const ExecutionSpaceReleaserName = "execution-space-releaser"
2626

2727
// ExecutionSpaceReleaser returns an ExecutionSpace releaser job specification.
28-
func ExecutionSpaceReleaser(executionSpace *v1alpha2.ExecutionSpace, environmentrequest *v1alpha1.EnvironmentRequest, image string, noDelete bool) *batchv1.Job {
28+
func ExecutionSpaceReleaser(executionSpace *v1alpha2.ExecutionSpace, environmentrequest *v1alpha1.EnvironmentRequest, image string, skipDeletingExecutionSpace bool) *batchv1.Job {
2929
return ReleaseJob(
3030
executionSpace.Name,
3131
ExecutionSpaceReleaserName,
3232
executionSpace.Namespace,
3333
environmentrequest,
34-
ExecutionSpaceReleaserContainer(executionSpace, image, noDelete),
34+
ExecutionSpaceReleaserContainer(executionSpace, image, skipDeletingExecutionSpace),
3535
)
3636
}
3737

3838
// ExecutionSpaceReleaserContainer returns an ExecutionSpace releaser container specification.
39-
func ExecutionSpaceReleaserContainer(executionSpace *v1alpha2.ExecutionSpace, image string, noDelete bool) corev1.Container {
39+
func ExecutionSpaceReleaserContainer(executionSpace *v1alpha2.ExecutionSpace, image string, skipDeletingExecutionSpace bool) corev1.Container {
4040
return ReleaseContainer(
4141
executionSpace.Name,
4242
ExecutionSpaceReleaserName,
4343
executionSpace.Namespace,
4444
image,
45-
noDelete,
45+
skipDeletingExecutionSpace,
4646
)
4747
}

internal/release/release.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,15 @@ func ReleaseJob(jobName, name, namespace string, environmentrequest *v1alpha1.En
7070
}
7171

7272
// ReleaseContainer returns a container specification.
73-
func ReleaseContainer(name, containerName, namespace, image string, skipDeletingExecutionSpace bool) corev1.Container {
73+
func ReleaseContainer(name, containerName, namespace, image string, noDelete bool) corev1.Container {
7474
args := []string{
7575
"-release",
7676
fmt.Sprintf("-namespace=%s", namespace),
7777
fmt.Sprintf("-name=%s", name),
7878
}
79-
if skipDeletingExecutionSpace {
79+
// noDelete tells a provider to not delete the resource it is responsible for.
80+
// Resource in this case being 'Iut', 'LogArea' or 'ExecutionSpace'
81+
if noDelete {
8082
args = append(args, "-nodelete")
8183
}
8284
return corev1.Container{

0 commit comments

Comments
 (0)