fix: collect min versions in CMakeLists.txt (#1128)

### Briefly, what does this PR introduce?
This defines all minimum dependency versions in one place, and uses them
in all find_package calls (or, in the case of Acts, immediately after
the find_package call).

### What kind of change does this PR introduce?
- [x] Bug fix (issue: duplication of version limits, absence of version
limits)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dmitry Kalinkin <[email protected]>

Author: 3 people

.github/workflows/linux-eic-shell.yml

@@ -133,7 +133,7 @@ jobs:
         platform-release: "${{ env.platform }}:${{ matrix.release }}"
         run: |
           # install this repo
-          CXX="${{ matrix.CXX }}" CXXFLAGS="${{ matrix.CXXFLAGS }}" cmake -B build -S . -DCMAKE_INSTALL_PREFIX=install -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_BUILD_TYPE=${{ matrix.CMAKE_BUILD_TYPE }} -DUSE_ASAN=ON -DUSE_TSAN=OFF -DUSE_UBSAN=ON
+          CXX="${{ matrix.CXX }}" CXXFLAGS="${{ matrix.CXXFLAGS }}" cmake --warn-uninitialized -B build -S . -DCMAKE_INSTALL_PREFIX=install -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_BUILD_TYPE=${{ matrix.CMAKE_BUILD_TYPE }} -DUSE_ASAN=ON -DUSE_TSAN=OFF -DUSE_UBSAN=ON
           cmake --build build -j $(getconf _NPROCESSORS_ONLN) --target install
           ccache --show-stats --verbose
           ccache --evict-older-than 7d

CMakeLists.txt

@@ -54,6 +54,23 @@ if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
                                                "MinSizeRel" "RelWithDebInfo")
 endif()
 
+# Minimal dependency versions
+set(Acts_VERSION_MIN 33.0.0)
+set(algorithms_VERSION_MIN 1.0.0)
+set(DD4hep_VERSION_MIN 1.21)
+set(EDM4EIC_VERSION_MIN 5.0)
+set(EDM4HEP_VERSION_MIN 0.7.1)
+set(Eigen3_VERSION_MIN 3.3)
+set(FastJet_VERSION_MIN 3)
+set(FastJetContrib_VERSION_MIN 1.46)
+set(fmt_VERSION_MIN 9.0.0)
+set(IRT_VERSION_MIN 1.0.5)
+set(JANA_VERSION_MIN 2.2.0)
+set(onnxruntime_MIN_VERSION 1.17)
+set(podio_VERSION_MIN 0.16)
+set(ROOT_VERSION_MIN 6.28)
+set(spdlog_VERSION_MIN 1.11.0)
+
 # Set default standard to C++20
 set(CMAKE_CXX_STANDARD_MIN 20)
 set(CMAKE_CXX_STANDARD
@@ -150,25 +167,28 @@ set(CMAKE_INSTALL_RPATH
 set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
 
 # Check and print what JANA2 is used
-find_package(JANA 2.2.0 REQUIRED)
+find_package(JANA ${JANA_VERSION_MIN} REQUIRED)
 message(STATUS "${CMAKE_PROJECT_NAME}: JANA2 CMake   : ${JANA_DIR}")
 message(STATUS "${CMAKE_PROJECT_NAME}: JANA2 includes: ${JANA_INCLUDE_DIR}")
 message(STATUS "${CMAKE_PROJECT_NAME}: JANA2 library : ${JANA_LIBRARY}")
 
 # Algorithms
-find_package(algorithms 1.0.0 REQUIRED Core)
+find_package(algorithms ${algorithms_VERSION_MIN} REQUIRED Core)
 
 # PODIO, EDM4HEP, EDM4EIC event models
-find_package(Eigen3 REQUIRED)
-find_package(podio REQUIRED)
-find_package(EDM4HEP 0.7.1 REQUIRED)
-find_package(EDM4EIC 5.0 REQUIRED)
-
-# spdlog
-find_package(spdlog REQUIRED)
+find_package(Eigen3 ${Eigen3_VERSION_MIN} REQUIRED)
+find_package(podio ${podio_VERSION_MIN} QUIET)
+if(NOT podio_FOUND)
+  find_package(podio 1.0 REQUIRED)
+endif()
+find_package(EDM4HEP ${EDM4HEP_VERSION_MIN} REQUIRED)
+find_package(EDM4EIC ${EDM4EIC_VERSION_MIN} REQUIRED)
 
 # fmt
-find_package(fmt 9.0.0 REQUIRED)
+find_package(fmt ${fmt_VERSION_MIN} REQUIRED)
+
+# spdlog
+find_package(spdlog ${spdlog_VERSION_MIN} REQUIRED)
 
 # Guidelines Support Library
 find_package(Microsoft.GSL CONFIG)
@@ -194,11 +214,10 @@ if(EDM4EIC_INTERFACE_COMPILE_DEFINITIONS)
 endif()
 
 # DD4Hep is required for the most of the part
-find_package(DD4hep REQUIRED)
+find_package(DD4hep ${DD4hep_VERSION_MIN} REQUIRED)
 
 # ACTS cmake-lint: disable=C0103
 find_package(Acts REQUIRED COMPONENTS Core PluginDD4hep PluginJson)
-set(Acts_VERSION_MIN "33.0.0")
 set(Acts_VERSION
     "${Acts_VERSION_MAJOR}.${Acts_VERSION_MINOR}.${Acts_VERSION_PATCH}")
 if(${Acts_VERSION} VERSION_LESS ${Acts_VERSION_MIN} AND NOT "${Acts_VERSION}"
@@ -218,7 +237,7 @@ if(NOT "cxx_std_${CMAKE_CXX_STANDARD}" IN_LIST ACTS_COMPILE_FEATURES)
 endif()
 
 # ROOT
-find_package(ROOT REQUIRED)
+find_package(ROOT ${ROOT_VERSION_MIN} REQUIRED)
 # Check that ROOT is compiled with a modern enough c++ standard
 get_target_property(ROOT_COMPILE_FEATURES ROOT::Core INTERFACE_COMPILE_FEATURES)
 if(NOT "cxx_std_${CMAKE_CXX_STANDARD}" IN_LIST ROOT_COMPILE_FEATURES)
@@ -231,7 +250,7 @@ endif()
 # ONNX Runtime
 option(USE_ONNX "Compile with ONNX support" ON)
 if(${USE_ONNX})
-  find_package(onnxruntime CONFIG)
+  find_package(onnxruntime ${onnxruntime_MIN_VERSION} CONFIG)
   add_compile_definitions(USE_ONNX)
 endif()
 

cmake/jana_plugin.cmake

@@ -219,11 +219,13 @@ macro(plugin_glob_all _name)
 
     # Finally add sources to library
     target_sources(${_name}_library PRIVATE ${LIB_SRC_FILES})
+
+    # Debug output if needed
+    message(VERBOSE
+            "plugin_glob_all:${_name}: PLUGIN_CC_FILE   ${PLUGIN_CC_FILE}")
   endif(${_name}_WITH_LIBRARY)
 
   # Debug output if needed
-  message(VERBOSE
-          "plugin_glob_all:${_name}: PLUGIN_CC_FILE   ${PLUGIN_CC_FILE}")
   message(VERBOSE "plugin_glob_all:${_name}: LIB_SRC_FILES    ${LIB_SRC_FILES}")
   message(VERBOSE
           "plugin_glob_all:${_name}: PLUGIN_SRC_FILES ${PLUGIN_SRC_FILES}")
@@ -237,7 +239,7 @@ endmacro()
 macro(plugin_add_algorithms _name)
 
   if(NOT algorithms_FOUND)
-    find_package(algorithms REQUIRED)
+    find_package(algorithms ${algorithms_VERSION_MIN} REQUIRED)
   endif()
 
   if(${_name}_WITH_LIBRARY)
@@ -261,7 +263,7 @@ endmacro()
 macro(plugin_add_dd4hep _name)
 
   if(NOT DD4hep_FOUND)
-    find_package(DD4hep REQUIRED)
+    find_package(DD4hep ${DD4hep_VERSION_MIN} REQUIRED)
   endif()
 
   plugin_link_libraries(${_name} DD4hep::DDCore DD4hep::DDRec)
@@ -272,7 +274,7 @@ endmacro()
 macro(plugin_add_eigen3 _name)
 
   if(NOT Eigen3_FOUND)
-    find_package(Eigen3 REQUIRED)
+    find_package(Eigen3 ${Eigen3_VERSION_MIN} REQUIRED)
   endif()
 
   plugin_link_libraries(${_name} Eigen3::Eigen)
@@ -284,7 +286,6 @@ macro(plugin_add_acts _name)
 
   if(NOT Acts_FOUND)
     find_package(Acts REQUIRED COMPONENTS Core PluginDD4hep PluginJson)
-    set(Acts_VERSION_MIN "33.0.0")
     set(Acts_VERSION
         "${Acts_VERSION_MAJOR}.${Acts_VERSION_MINOR}.${Acts_VERSION_PATCH}")
     if(${Acts_VERSION} VERSION_LESS ${Acts_VERSION_MIN}
@@ -325,7 +326,7 @@ endmacro()
 macro(plugin_add_irt _name)
 
   if(NOT IRT_FOUND)
-    find_package(IRT REQUIRED)
+    find_package(IRT ${IRT_VERSION_MIN} REQUIRED)
   endif()
 
   # FIXME: IRTConfig.cmake sets INTERFACE_INCLUDE_DIRECTORIES to
@@ -346,15 +347,18 @@ endmacro()
 macro(plugin_add_event_model _name)
 
   if(NOT podio_FOUND)
-    find_package(podio REQUIRED)
+    find_package(podio ${podio_VERSION_MIN} QUIET)
+    if(NOT podio_FOUND)
+      find_package(podio 1.0 REQUIRED)
+    endif()
   endif()
 
   if(NOT EDM4HEP_FOUND)
-    find_package(EDM4HEP REQUIRED)
+    find_package(EDM4HEP ${EDM4HEP_VERSION_MIN} REQUIRED)
   endif()
 
   if(NOT EDM4EIC_FOUND)
-    find_package(EDM4EIC REQUIRED)
+    find_package(EDM4EIC ${EDM4EIC_VERSION_MIN} REQUIRED)
   endif()
 
   # Add include directories
@@ -373,7 +377,7 @@ endmacro()
 macro(plugin_add_cern_root _name)
 
   if(NOT ROOT_FOUND)
-    find_package(ROOT REQUIRED)
+    find_package(ROOT ${ROOT_VERSION_MIN} REQUIRED)
   endif()
 
   # Add libraries
@@ -385,7 +389,7 @@ endmacro()
 macro(plugin_add_fastjet _name)
 
   if(NOT FASTJET_FOUND)
-    find_package(FastJet REQUIRED)
+    find_package(FastJet ${FastJet_VERSION_MIN} REQUIRED)
   endif()
 
   # Add include directories
@@ -401,7 +405,7 @@ endmacro()
 macro(plugin_add_fastjettools _name)
 
   if(NOT FJTOOLS_FOUND)
-    find_package(FastJetTools REQUIRED)
+    find_package(FastJetTools ${FastJet_VERSION_MIN} REQUIRED)
   endif()
 
   # Add include directories
@@ -417,7 +421,7 @@ endmacro()
 macro(plugin_add_fastjetcontrib _name)
 
   if(NOT FJCONTRIB_FOUND)
-    find_package(FastJetContrib REQUIRED)
+    find_package(FastJetContrib ${FastJetContrib_VERSION_MIN} REQUIRED)
   endif()
 
   # Add include directories
@@ -433,7 +437,7 @@ endmacro()
 macro(plugin_add_onnxruntime _name)
 
   if(NOT onnxruntime_FOUND)
-    find_package(onnxruntime CONFIG)
+    find_package(onnxruntime ${onnxruntime_MIN_VERSION} CONFIG)
   endif()
 
   # Add libraries