Merge pull request #156 from ecmwf/fix/aarch64-strcmp-issue

danovaro · web-flow · commit 800531faf57c · 2025-02-14T12:17:01.000Z
Feature: use  use C++ std::string::compare in StringContent::compareString
diff --git a/src/eckit/value/StringContent.cc b/src/eckit/value/StringContent.cc
@@ -66,7 +66,7 @@ int StringContent::compare(const Content& other) const {
 }
 
 int StringContent::compareString(const StringContent& other) const {
-    return ::strcmp(value_.c_str(), other.value_.c_str());
+    return value_.compare(other.value_);
 }
 
 void StringContent::value(std::string& s) const {

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ int StringContent::compare(const Content& other) const {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`int StringContent::compareString(const StringContent& other) const {`
`69`		`- return ::strcmp(value_.c_str(), other.value_.c_str());`
	`69`	`+ return value_.compare(other.value_);`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`void StringContent::value(std::string& s) const {`