Add pre-commit feature to devcontainer

It supports to spot easy to detect issues before committing code and
reduce the number of failed CI runs and review cycles.

Ensure the S-CORE depends on the pre-commit feature so that it is always
because it installs scripts using it.

Author: lurtz

src/s-core-devcontainer/.devcontainer/devcontainer-lock.json

@@ -5,6 +5,11 @@
       "resolved": "ghcr.io/devcontainers-community/features/llvm@sha256:4f464ab97a59439286a55490b55ba9851616f6f76ac3025e134127ac08ad79e2",
       "integrity": "sha256:4f464ab97a59439286a55490b55ba9851616f6f76ac3025e134127ac08ad79e2"
     },
+    "ghcr.io/devcontainers-extra/features/pre-commit:2": {
+      "version": "2.0.18",
+      "resolved": "ghcr.io/devcontainers-extra/features/pre-commit@sha256:6e0bb2ce80caca1d94f44dab5d0653d88a1c00984e590adb7c6bce012d0ade6e",
+      "integrity": "sha256:6e0bb2ce80caca1d94f44dab5d0653d88a1c00984e590adb7c6bce012d0ade6e"
+    },
     "ghcr.io/devcontainers/features/common-utils": {
       "version": "2.5.4",
       "resolved": "ghcr.io/devcontainers/features/common-utils@sha256:00fd45550f578d9d515044d9e2226e908dbc3d7aa6fcb9dee4d8bdb60be114cf",

src/s-core-devcontainer/.devcontainer/devcontainer.json

@@ -48,7 +48,6 @@
         "./s-core-local"
     ],
     "remoteUser": "vscode",
-
     "customizations": {
         "vscode": {
             "extensions": [

src/s-core-devcontainer/.devcontainer/s-core-local/devcontainer-feature.json

@@ -3,12 +3,18 @@
     "id": "s-core-local",
     "version": "1.0.0",
     "description": "Tools which are not available as already existing development container feature",
+    "dependsOn": {
+        "ghcr.io/devcontainers-extra/features/pre-commit:2": {
+            "version": "4.5.1"
+        }
+    },
     "onCreateCommand": "/devcontainer/features/s-core-local/on_create_command.sh",
     "postCreateCommand": {
         // The repos in S-CORE may use different Bazel versions. This ensures that the required version is installed.
         // Should be removed once we provide versions of the devcontainer.
         "Install matching Bazel version": "bash /devcontainer/features/s-core-local/install_matching_bazel_version.sh",
-        "Setup persistent bash history": "bash /devcontainer/features/s-core-local/setup_command_history.sh"
+        "Setup persistent bash history": "bash /devcontainer/features/s-core-local/setup_command_history.sh",
+        "Enable pre-commit hooks": "bash /devcontainer/features/s-core-local/enable_pre_commit_hooks.sh"
     },
     "mounts": [
         {

src/s-core-devcontainer/.devcontainer/s-core-local/enable_pre_commit_hooks.sh

@@ -0,0 +1,12 @@
+#!/usr/bin/env bash
+
+PRE_COMMIT_CONFIG_FILE=".pre-commit-config.yaml"
+
+if [[ -f "${PRE_COMMIT_CONFIG_FILE}" ]]
+then
+    echo "Pre-commit configuration found (${PRE_COMMIT_CONFIG_FILE})"
+    $PIPX_BIN_DIR/pre-commit install
+else
+    echo "No pre-commit configuration found (${PRE_COMMIT_CONFIG_FILE})"
+    echo "Skipping pre-commit hook's installation"
+fi

src/s-core-devcontainer/.devcontainer/s-core-local/tests/test_default.sh

@@ -4,6 +4,9 @@ set -euo pipefail
 # Read tool versions + metadata into environment variables
 . /devcontainer/features/s-core-local/versions.sh
 
+# pre-commit, it is available via $PATH in login shells, but not in non-login shells
+check "validate pre-commit is working and has the correct version" bash -c "$PIPX_BIN_DIR/pre-commit --version | grep '4.5.1'"
+
 # Common tooling
 # For an unknown reason, dot -V reports on Ubuntu Noble a version 2.43.0, while the package has a different version.
 # Hence, we have to work around that.