Allow customization of the browser style in the "BrowserViewer" class.

[lak-proddev]

I have a use case where I want to create a view with an embedded browser. I want to customize the browser style of SWT.EDGE in the BrowserViewer class. The current code does not allow changing it in the subclass.

org.eclipse.ui.internal.browser.BrowserViewer.BrowserViewer(Composite, int)

this.browser = new Browser(this, SWT.NONE);

My suggestion is

// Add a protected method to allow custom styles
protected int getBrowserStyle() {
    return SWT.NONE; // Default style
}

// Use the method to set the style for the Browser object
this.browser = new Browser(this, getBrowserStyle());

[fedejeanne]

Thank you for reporting this, @lak-proddev !

I see the point of the style-bits not reaching the instantiation of the browser (feel free to propose a PR to fix that) but Edge is the new default so there should be no need to pass SWT.EDGE as a parameter to the constructor.

Which version are you using? Can you provide a snippet to reproduce the error or at least mention an existing snippet/view that exposes this behavior so we can double-check?

[lak-proddev]

Edge is the new default so there should be no need to pass SWT.EDGE as a parameter to the constructor.

Okay, Thanks. I am not aware of it. When was it changed?

Which version are you using?

My product TP is based on version 2024-06

Can you provide a snippet to reproduce the error or at least mention an existing snippet/view that exposes this behavior so we can double-check?

We are unable to launch it in the internal web browser. Not only this. any JS-based web UI.
https://google.github.io/adk-docs/get-started/quickstart/#dev-ui-adk-web

feel free to propose a PR to fix that
#3036

[fedejeanne]

Edge is the default since 4.35 / 2025-03 (See N&N). Any chance to upgrade and test?

It's still not clear to me what are you trying to open in the internal browser (I assume you meant this one?)

Can you provide a problematic URL that we can access and test?