Skip to content

QuickDiff for embedded text documents #2624

@mx990

Description

@mx990

We at Eclipse 4diac are using a text editor tab inside a multi-page editor for text documents embedded inside XML files. The plain-text content is extracted out of the larger XML file via a custom document provider.

The default QuickDiff reference source reads the file contents directly, without going through the document provider of the editor. In our use case, this unfortunately leads to bogus differences for the XML content surrounding the plain-text embeddings. We have thus decided to disable QuickDiff in our embedded text editors for now.

I would like to suggest using the document provider of the editor to obtain the reference document instead of loading it directly. To that end, I would suggest adding a new interface IQuickDiffDocumentProvider, optionally implemented by document providers allowing them to provide a custom reference document. Of course, I am also open to other ideas for solving the problem.

I am hoping for a constructive discussion on possible solutions, after which I would also be happy to implement the feature myself if possible and reasonable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions