#748: LrcLib fetcher - don't crash if song has no artist name tagged

dweymouth · dweymouth · commit e883c387f3f4 · 2025-11-14T08:40:47.000-08:00
diff --git a/backend/lyricsmanager.go b/backend/lyricsmanager.go
@@ -63,7 +63,11 @@ func (lm *LyricsManager) fetchLyrics(ctx context.Context, song *mediaprovider.Tr
 		}
 	}
 	if lyrics == nil && lm.lrclib != nil {
-		lyrics, err = lm.lrclib.FetchLrcLibLyrics(song.Title, song.ArtistNames[0], song.Album, int(song.Duration.Seconds()))
+		artist := ""
+		if len(song.ArtistNames) > 0 {
+			artist = song.ArtistNames[0]
+		}
+		lyrics, err = lm.lrclib.FetchLrcLibLyrics(song.Title, artist, song.Album, int(song.Duration.Seconds()))
 		if err != nil {
 			log.Println(err.Error())
 		}

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,11 @@ func (lm LyricsManager) fetchLyrics(ctx context.Context, song mediaprovider.Tr`
`63`	`63`	`}`
`64`	`64`	`}`
`65`	`65`	`if lyrics == nil && lm.lrclib != nil {`
`66`		`- lyrics, err = lm.lrclib.FetchLrcLibLyrics(song.Title, song.ArtistNames[0], song.Album, int(song.Duration.Seconds()))`
	`66`	`+ artist := ""`
	`67`	`+ if len(song.ArtistNames) > 0 {`
	`68`	`+ artist = song.ArtistNames[0]`
	`69`	`+ }`
	`70`	`+ lyrics, err = lm.lrclib.FetchLrcLibLyrics(song.Title, artist, song.Album, int(song.Duration.Seconds()))`
`67`	`71`	`if err != nil {`
`68`	`72`	`log.Println(err.Error())`
`69`	`73`	`}`