Skip to content

Commit f71d910

Browse files
committed
Mark upgrade-transaction-lifecycle-committed.any.js as unstable
1 parent 5600bbb commit f71d910

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# See discussion in https://github.com/dumbmatter/fakeIndexedDB/issues/167
2+
# The issue here is a subtle timing issue with setTimeout vs setImmediate that's not straightforward to resolve in Node
3+
expectTimeout = "UNSTABLE"
4+
5+
["in a setTimeout(0) callback after the complete event is fired for a committed transaction"]
6+
expectation = "UNSTABLE"

src/test/web-platform-tests/run-all.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,11 @@ for (const absFilename of filenames) {
134134
});
135135
}
136136

137-
if (generatedManifest.expectTimeout) {
137+
if (expectedManifest?.contents?.expectTimeout === "UNSTABLE") {
138+
// If the timeout is unstable, then don't pass/fail based on whether we actually got a timeout or not
139+
generatedManifest.expectTimeout = "UNSTABLE";
140+
numExpectedTimeouts += 1;
141+
} else if (generatedManifest.expectTimeout) {
138142
if (expectedManifest?.contents?.expectTimeout) {
139143
numExpectedTimeouts += 1;
140144
} else {

0 commit comments

Comments
 (0)