Skip to content

Commit cf18c9f

Browse files
Add test for prod deps (#1759)
* Add test for prod deps * Make test only for injected * Move minimist to deps * Move type generator from dev deps * Lint fix * Install all but only test injected * Make config non dev dep * Move esbuild to be a dep * Move urlpattern to be a non dev
1 parent 01c89b1 commit cf18c9f

File tree

4 files changed

+35
-70
lines changed

4 files changed

+35
-70
lines changed

.github/workflows/tests.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,3 +108,18 @@ jobs:
108108
- name: Deploy to GitHub Pages
109109
id: deployment
110110
uses: actions/deploy-pages@v4
111+
112+
# This job ensures all runtime dependencies for the injected/ subproject are correctly listed in 'dependencies' (not 'devDependencies')
113+
# by running the build with only production dependencies installed in injected/. It will fail if any required dependency is missing.
114+
production-deps:
115+
runs-on: ubuntu-latest
116+
steps:
117+
- uses: actions/checkout@v4
118+
- name: Use Node.js
119+
uses: actions/setup-node@v4
120+
with:
121+
node-version-file: '.nvmrc'
122+
- name: Install production dependencies only (injected/)
123+
run: npm ci --production
124+
- name: Build with production dependencies (injected/)
125+
run: cd injected && npm run build

injected/package.json

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,20 @@
2828
"dependencies": {
2929
"parse-address": "^1.1.2",
3030
"seedrandom": "^3.0.5",
31-
"sjcl": "^1.0.8"
31+
"sjcl": "^1.0.8",
32+
"minimist": "^1.2.8",
33+
"@duckduckgo/privacy-configuration": "github:duckduckgo/privacy-configuration#2c569c49990bae4ac83578fc9eaef282489d7926",
34+
"esbuild": "^0.25.4",
35+
"urlpattern-polyfill": "^10.1.0"
3236
},
3337
"devDependencies": {
3438
"@canvas/image-data": "^1.0.0",
35-
"@duckduckgo/privacy-configuration": "github:duckduckgo/privacy-configuration#2c569c49990bae4ac83578fc9eaef282489d7926",
3639
"@fingerprintjs/fingerprintjs": "^4.6.2",
3740
"@types/chrome": "^0.0.326",
3841
"@types/jasmine": "^5.1.8",
3942
"@types/node": "^24.0.3",
4043
"@typescript-eslint/eslint-plugin": "^8.34.1",
4144
"fast-check": "^4.1.1",
42-
"jasmine": "^5.7.1",
43-
"minimist": "^1.2.8"
45+
"jasmine": "^5.7.1"
4446
}
4547
}

0 commit comments

Comments
 (0)