fix: another thread safety issue in MapCache#1130
Merged
Merged
Conversation
In 2025d75, we improved the thread safety of the MapCache class by implementing all methods of the Map interface in the class itself, instead of inheriting the (non-thread-safe) default implementations of the interface. On closer inspection, it turns out that the putIfAbsent method was already implemented, but in a non-thread-safe way.
rubenporras
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 2025d75, we improved the thread safety of the MapCache class by implementing all methods of the Map interface in the class itself, instead of inheriting the (non-thread-safe) default implementations of the interface. On closer inspection, it turns out that the putIfAbsent method was already implemented, but in a non-thread-safe way.