chore: remove LfNormalizingFileSystemAccess (now superseded by config)

Delete `LfNormalizingFileSystemAccess.java` and remove its wrap calls
from `CheckGenerator.xtend` and `CheckCfgGenerator.xtend`.

The decorator was introduced in PR #1331 as a post-hoc normaliser
against CRLF leaks from various emission paths. After:

- step 1 of this stack (#1352) — `.mwe2` `lineDelimiter` and
  `ddk-configuration` runtime prefs both flipped to `\n`
- step 2 (#1353) — `line.separator=\n` propagated to every
  source-bearing bundle's `.settings/org.eclipse.core.runtime.prefs`
- the preceding commit on this branch — `KeywordAnalysisHelper` no
  longer uses `PrintWriter.println()`

…every emission path now produces LF natively. The wrapper is no-op
work and the conditional `instanceof IFileSystemAccess2` cast it
introduced is no longer needed.

Closes #1345 — the planned extension of the same wrapper to
`Scope` / `Format` / `Export` generators is no longer needed for the
same reason. Those generators are already clean of `Strings.newLine()`,
`System.lineSeparator()`, and hardcoded `"\r\n"` emission (audited).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: joaodinissf

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckGenerator.xtend

@@ -16,7 +16,6 @@ import com.google.inject.Inject
 import org.eclipse.emf.ecore.resource.Resource
 import org.eclipse.xtext.generator.AbstractFileSystemAccess
 import org.eclipse.xtext.generator.IFileSystemAccess
-import org.eclipse.xtext.generator.IFileSystemAccess2
 import org.eclipse.xtext.xbase.compiler.JvmModelGenerator
 
 import static org.eclipse.xtext.xbase.lib.IteratorExtensions.*
@@ -37,24 +36,23 @@ class CheckGenerator extends JvmModelGenerator {
   @Inject ICheckGeneratorConfigProvider generatorConfigProvider;
 
   override void doGenerate(Resource resource, IFileSystemAccess fsa) {
-    val lfFsa = new LfNormalizingFileSystemAccess(fsa as IFileSystemAccess2)
-    super.doGenerate(resource, lfFsa); // Generate validator, catalog, and preference initializer from inferred Jvm models.
+    super.doGenerate(resource, fsa); // Generate validator, catalog, and preference initializer from inferred Jvm models.
     val config = generatorConfigProvider.get(resource?.URI);
     for (catalog : toIterable(resource.allContents).filter(typeof(CheckCatalog))) {
 
-      lfFsa.generateFile(catalog.issueCodesFilePath, catalog.compileIssueCodes)
-      lfFsa.generateFile(catalog.standaloneSetupPath, catalog.compileStandaloneSetup)
+      fsa.generateFile(catalog.issueCodesFilePath, catalog.compileIssueCodes)
+      fsa.generateFile(catalog.standaloneSetupPath, catalog.compileStandaloneSetup)
 
       // change output path for service registry
-      lfFsa.generateFile(
+      fsa.generateFile(
         CheckUtil::serviceRegistryClassName,
         CheckGeneratorConstants::CHECK_REGISTRY_OUTPUT,
         catalog.generateServiceRegistry(CheckUtil::serviceRegistryClassName, fsa)
       )
       // generate documentation for SCA-checks only
       if(config !== null && (config.doGenerateDocumentationForAllChecks || !config.generateLanguageInternalChecks)){
         // change output path for html files to docs/
-        lfFsa.generateFile(catalog.docFileName, CheckGeneratorConstants::CHECK_DOC_OUTPUT, catalog.compileDoc)
+        fsa.generateFile(catalog.docFileName, CheckGeneratorConstants::CHECK_DOC_OUTPUT, catalog.compileDoc)
       }
     }
   }

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/LfNormalizingFileSystemAccess.java

@@ -10,14 +10,12 @@
  *******************************************************************************/
 package com.avaloq.tools.ddk.checkcfg.generator
 
-import com.avaloq.tools.ddk.check.generator.LfNormalizingFileSystemAccess
 import com.avaloq.tools.ddk.check.runtime.configuration.ICheckConfigurationStoreService
 import com.avaloq.tools.ddk.checkcfg.checkcfg.CheckConfiguration
 import com.google.inject.Inject
 import org.eclipse.emf.ecore.resource.Resource
 import org.eclipse.xtext.generator.AbstractFileSystemAccess
 import org.eclipse.xtext.generator.IFileSystemAccess
-import org.eclipse.xtext.generator.IFileSystemAccess2
 import org.eclipse.xtext.generator.IGenerator
 
 import static org.eclipse.xtext.xbase.lib.IteratorExtensions.*
@@ -39,9 +37,8 @@ class CheckCfgGenerator implements IGenerator {
     if (fsa instanceof AbstractFileSystemAccess) {
       fsa.setOutputPath(outputPath)
     }
-    val lfFsa = new LfNormalizingFileSystemAccess(fsa as IFileSystemAccess2)
     for (configuration:toIterable(resource.allContents).filter(typeof(CheckConfiguration))) {
-      lfFsa.generateFile(configuration.fileName, configuration.compile)
+      fsa.generateFile(configuration.fileName, configuration.compile)
     }
   }