-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Hi there,
We've been preparing a new major release for ggplot2 and found an issue during a reverse dependency check.
The issue is described in tidyverse/ggplot2#6498, where you're welcome to raise discussion.
The issue isn't with your packaged code, but with these expectations:
spacejamr/tests/testthat/test-generics.R
Lines 8 to 19 in bf4682d
test_that("we can plot objects created with the spacejamr package", { | |
# Plot method for spacejamr class | |
expect_identical(class(plot(RI)), c("gg", "ggplot")) | |
# Plot method for PointSim classes | |
expect_identical(class(plot(ri_points)), c("gg", "ggplot")) | |
# Plot method for NetSim classes | |
expect_identical(class(plot(pl)), c("ggraph", "gg", "ggplot")) | |
}) |
A similar expectation might be in other tests. You can test your code with the development version of ggplot2 by installing it as follows:
# install.packages("pak")
pak::pak("tidyverse/ggplot2")
We aim to release the new ggplot2 version in about 2 weeks, and hope you can submit a fix to CRAN around that time. Hopefully this will inform you in a timely manner.
Best wishes,
Teun
Metadata
Metadata
Assignees
Labels
No labels