Revert number inputs for fields with labels on the problem set detail page.

This is a quick fix that will make things function for now, and is good
for a hotfix.  This just reverts all of the fields that were switched to
number inputs and that have labels for special negative values back to
text inputs and the functionality prior to WeBWorK 2.20.

The fields that do not have those labels can still be number inputs.
That will work fine for those.

Also set the default for showMeAnother to the "Course Default" instead
of "Never" which is what it should be.

This resolves issue openwebwork#2820 for the current release.

We can try to do better for the next release, but I don't see any other
easy way to fix this that is appropriate for a hotfix.

Author: drgrice1

lib/WeBWorK/ContentGenerator/Instructor/ProblemSetDetail.pm

@@ -480,7 +480,7 @@ use constant FIELD_PROPERTIES => {
 	},
 	max_attempts => {
 		name     => x('Max Attempts'),
-		type     => [ -1, undef, 1 ],
+		type     => 'edit',
 		size     => 6,
 		override => 'any',
 		default  => '-1',
@@ -493,10 +493,10 @@ use constant FIELD_PROPERTIES => {
 	},
 	showMeAnother => {
 		name     => x('Show Me Another'),
-		type     => [ -2, undef, 1 ],
+		type     => 'edit',
 		size     => '6',
 		override => 'any',
-		default  => '-1',
+		default  => '-2',
 		labels   => {
 			'-1' => x('Never'),
 			'-2' => x('Course Default'),
@@ -509,7 +509,7 @@ use constant FIELD_PROPERTIES => {
 	},
 	showHintsAfter => {
 		name     => x('Show Hints After'),
-		type     => [ -2, undef, 1 ],
+		type     => 'edit',
 		size     => '6',
 		override => 'any',
 		default  => '-2',
@@ -526,7 +526,7 @@ use constant FIELD_PROPERTIES => {
 	},
 	prPeriod => {
 		name     => x('Rerandomize After'),
-		type     => [ -1, undef, 1 ],
+		type     => 'edit',
 		size     => '6',
 		override => 'any',
 		default  => '-1',
@@ -606,7 +606,7 @@ use constant FIELD_PROPERTIES => {
 	},
 	att_to_open_children => {
 		name     => x('Attempt Threshold for Children'),
-		type     => [ -1, undef, 1 ],
+		type     => 'edit',
 		size     => 6,
 		override => 'any',
 		default  => '0',
@@ -960,10 +960,9 @@ sub fieldHTML ($c, $userID, $setID, $problemID, $globalRecord, $userRecord, $fie
 			} elsif ($number) {
 				$input = $c->number_field(
 					@field_args,
-					min         => ($properties{type}[0] || 0),
-					max         => ($properties{type}[1] || undef),
-					step        => ($properties{type}[2] || 1),
-					placeholder => $value,
+					min  => ($properties{type}[0] || 0),
+					max  => ($properties{type}[1] || undef),
+					step => ($properties{type}[2] || 1),
 					$forUsers && $canOverride ? (placeholder => $c->maketext('Set Default')) : ()
 				);
 			} else {