Split ILLink test classes to improve Helix shard distribution#53453
Merged
marcpopMSFT merged 2 commits intomainfrom Mar 31, 2026
Merged
Split ILLink test classes to improve Helix shard distribution#53453marcpopMSFT merged 2 commits intomainfrom
marcpopMSFT merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the ILLink publish test suite to improve Helix shard/workitem distribution by splitting large test classes into additional smaller classes, reducing long-running shards in PR pipelines.
Changes:
- Split portions of existing ILLink test coverage into three new test classes/files:
GivenThatWeWantToRunILLink1b,GivenThatWeWantToRunILLink2b, andGivenThatWeWantToRunILLink3b. - Removed the moved tests from
GivenThatWeWantToRunILLink.cswhile keeping total test coverage/count the same. - Preserved existing test logic/assertions while improving scheduling granularity.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs | Removes test methods that were moved into new split-out classes; keeps remaining ILLink test classes intact. |
| test/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink1b.cs | New split-out class containing roughly half of the former ILLink1 tests. |
| test/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink2b.cs | New split-out class containing roughly half of the former ILLink2 tests. |
| test/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink3b.cs | New split-out class containing roughly half of the former ILLink3 tests. |
test/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink2b.cs
Outdated
Show resolved
Hide resolved
marcpopMSFT
force-pushed
the
marcpopMSFT-PRPerfimprovements
branch
from
fea5094 to
ac88dbe
Compare
Further split GivenThatWeWantToRunILLink1/2/3 classes in Microsoft.NET.Publish.Tests to reduce the 16-21 minute Helix shards (the 2nd-longest items in the PR build pipeline). Each ILLink class is split roughly in half: - ILLink1: 27 tests -> 14 (original) + 13 (ILLink1b) - ILLink2: 15 tests -> 8 (original) + 7 (ILLink2b) - ILLink3: 14 tests -> 7 (original) + 7 (ILLink3b) Total test count preserved: 56 across 6 classes. The AssemblyScheduler (methodLimit=16) will now distribute these into more balanced shards, reducing maximum shard execution time.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
marcpopMSFT
force-pushed
the
marcpopMSFT-PRPerfimprovements
branch
from
ac88dbe to
1bc368e
Compare
3 tasks
Member
Author
|
See #53578 for more analysis |
Member
Author
|
@dotnet/illink mind providing a review? This was in the low hanging fruit that copilot suggested in analysis of our PR build times. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/dotnet/sdk/blob/ff559048ffe5b233c53abb0dcd64fcc469ffa1e4/documentation/general/pr-build-performance-analysis.md for more details. This was a low hanging fruit option for improving PR performance.
Further split GivenThatWeWantToRunILLink1/2/3 classes in Microsoft.NET.Publish.Tests to reduce the 16-21 minute Helix shards (the 2nd-longest items in the PR build pipeline).
Each ILLink class is split roughly in half:
Total test count preserved: 56 across 6 classes.
The AssemblyScheduler (methodLimit=16) will now distribute these into more balanced shards, reducing maximum shard execution time.