[Foundation] Fix nullability in NSUrlSession. #24269
Conversation
This is file 12 of 47 files with nullability disabled in Foundation. Changes: - Enabled nullable reference types - Made tmpfile nullable and added null check in Initialize method to handle the case where Location.Path could be null - Replaced xml include directive with inline documentation for Dispose(bool) method - Removed NSUrlSessionDownloadTaskRequest.xml file as it only contained the now-inlined documentation - Added XML documentation for the finalizer - Improved XML documentation for Dispose() and Dispose(bool) methods with see cref attributes - Fixed class summary to be more concise and removed redundant repetition in remarks - Removed unnecessary whitespace in comments Contributes towards #17285.
✅ [CI Build #70fe4ae] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #70fe4ae] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #70fe4ae] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #70fe4ae] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #70fe4ae] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #70fe4ae] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
💻 [CI Build #70fe4ae] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #70fe4ae] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
🔥 [CI Build #70fe4ae] Test results 🔥Test results❌ Tests failed on VSTS: test results 1 tests crashed, 2 tests failed, 69 tests passed. Failures❌ fsharp tests
Html Report (VSDrops) Download ❌ linker tests🔥 Failed catastrophically on VSTS: test results - linker (no summary found). Html Report (VSDrops) Download ❌ monotouch tests (tvOS)
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is file 12 of 47 files with nullability disabled in Foundation.
Changes:
Contributes towards #17285.