Skip to content

Commit b749626

Browse files
committed
Feedback.
1 parent 699122a commit b749626

File tree

1 file changed

+33
-33
lines changed

1 file changed

+33
-33
lines changed

test/EFCore.Sqlite.FunctionalTests/Query/PrimitiveCollectionsQuerySqliteTest.cs

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -15895,39 +15895,39 @@ FROM json_each("p"."Ints") AS "i"
1589515895
""");
1589615896
}
1589715897

15898-
// TODO: The base implementations no longer compile since https://github.com/dotnet/runtime/pull/110197 (Contains overload added with
15899-
// optional parameter, not supported in expression trees). #35547 is tracking on the EF side.
15900-
//
15901-
//
15902-
// public override async Task Column_collection_of_nullable_ints_Contains(bool async)
15903-
// {
15904-
// await base.Column_collection_of_nullable_ints_Contains(async);
15905-
//
15906-
// AssertSql(
15907-
// """
15908-
// SELECT "p"."Id", "p"."Bool", "p"."Bools", "p"."DateTime", "p"."DateTimes", "p"."Enum", "p"."Enums", "p"."Int", "p"."Ints", "p"."NullableInt", "p"."NullableInts", "p"."NullableString", "p"."NullableStrings", "p"."NullableWrappedId", "p"."NullableWrappedIdWithNullableComparer", "p"."String", "p"."Strings", "p"."WrappedId"
15909-
// FROM "PrimitiveCollectionsEntity" AS "p"
15910-
// WHERE 10 IN (
15911-
// SELECT "n"."value"
15912-
// FROM json_each("p"."NullableInts") AS "n"
15913-
// )
15914-
// """);
15915-
// }
15916-
//
15917-
// public override async Task Column_collection_of_nullable_ints_Contains_null(bool async)
15918-
// {
15919-
// await base.Column_collection_of_nullable_ints_Contains_null(async);
15920-
//
15921-
// AssertSql(
15922-
// """
15923-
// SELECT "p"."Id", "p"."Bool", "p"."Bools", "p"."DateTime", "p"."DateTimes", "p"."Enum", "p"."Enums", "p"."Int", "p"."Ints", "p"."NullableInt", "p"."NullableInts", "p"."NullableString", "p"."NullableStrings", "p"."NullableWrappedId", "p"."NullableWrappedIdWithNullableComparer", "p"."String", "p"."Strings", "p"."WrappedId"
15924-
// FROM "PrimitiveCollectionsEntity" AS "p"
15925-
// WHERE EXISTS (
15926-
// SELECT 1
15927-
// FROM json_each("p"."NullableInts") AS "n"
15928-
// WHERE "n"."value" IS NULL)
15929-
// """);
15930-
// }
15898+
// TODO: The base implementations no longer compile since https://github.com/dotnet/runtime/pull/110197 (Contains overload added with
15899+
// optional parameter, not supported in expression trees). #35547 is tracking on the EF side.
15900+
//
15901+
//
15902+
// public override async Task Column_collection_of_nullable_ints_Contains(bool async)
15903+
// {
15904+
// await base.Column_collection_of_nullable_ints_Contains(async);
15905+
//
15906+
// AssertSql(
15907+
// """
15908+
// SELECT "p"."Id", "p"."Bool", "p"."Bools", "p"."DateTime", "p"."DateTimes", "p"."Enum", "p"."Enums", "p"."Int", "p"."Ints", "p"."NullableInt", "p"."NullableInts", "p"."NullableString", "p"."NullableStrings", "p"."NullableWrappedId", "p"."NullableWrappedIdWithNullableComparer", "p"."String", "p"."Strings", "p"."WrappedId"
15909+
// FROM "PrimitiveCollectionsEntity" AS "p"
15910+
// WHERE 10 IN (
15911+
// SELECT "n"."value"
15912+
// FROM json_each("p"."NullableInts") AS "n"
15913+
// )
15914+
// """);
15915+
// }
15916+
//
15917+
// public override async Task Column_collection_of_nullable_ints_Contains_null(bool async)
15918+
// {
15919+
// await base.Column_collection_of_nullable_ints_Contains_null(async);
15920+
//
15921+
// AssertSql(
15922+
// """
15923+
// SELECT "p"."Id", "p"."Bool", "p"."Bools", "p"."DateTime", "p"."DateTimes", "p"."Enum", "p"."Enums", "p"."Int", "p"."Ints", "p"."NullableInt", "p"."NullableInts", "p"."NullableString", "p"."NullableStrings", "p"."NullableWrappedId", "p"."NullableWrappedIdWithNullableComparer", "p"."String", "p"."Strings", "p"."WrappedId"
15924+
// FROM "PrimitiveCollectionsEntity" AS "p"
15925+
// WHERE EXISTS (
15926+
// SELECT 1
15927+
// FROM json_each("p"."NullableInts") AS "n"
15928+
// WHERE "n"."value" IS NULL)
15929+
// """);
15930+
// }
1593115931

1593215932
public override async Task Column_collection_of_strings_contains_null(bool async)
1593315933
{

0 commit comments

Comments
 (0)