[Rollout] Production rollout 2025-04-30-III (#4784)

#4774

Author: adamzip

src/Microsoft.DotNet.Darc/DarcLib/GitHubClient.cs

@@ -592,7 +592,7 @@ private static void UpdateCheckRun(CheckRunUpdate newUpdateCheckRun, MergePolicy
         {
             newUpdateCheckRun.Status = CheckStatus.InProgress;
         }
-        else if (result.Status == MergePolicyEvaluationStatus.DecisiveSuccess)
+        else if (result.Status == MergePolicyEvaluationStatus.DecisiveSuccess || result.Status == MergePolicyEvaluationStatus.TransientSuccess)
         {
             newUpdateCheckRun.Conclusion = "success";
             newUpdateCheckRun.CompletedAt = DateTime.Now;

src/Microsoft.DotNet.Darc/DarcLib/VirtualMonoRepo/VmrRegistrations.cs

@@ -58,6 +58,27 @@ public static IServiceCollection AddSingleVmrSupport(
         return AddVmrManagers(services, gitLocation, gitHubToken, azureDevOpsToken);
     }
 
+    /// <summary>
+    /// Registers dependencies for GitNativeRepoCloner.
+    /// It only supports Azure DevOps connections and it assumes that a dependency on IAzureDevOpsTokenProvider has been registered.
+    /// </summary>
+    public static IServiceCollection AddGitNativeRepoClonerSupport(this IServiceCollection services)
+    {
+        services.TryAddTransient<IGitRepoCloner, GitNativeRepoCloner>();
+        services.TryAddSingleton<IRemoteTokenProvider>(sp =>
+        {
+            var azdoTokenProvider = sp.GetRequiredService<IAzureDevOpsTokenProvider>();
+            return new RemoteTokenProvider(azdoTokenProvider, null);
+        });
+        services.TryAddTransient<ILocalGitClient, LocalGitClient>();
+        services.TryAddTransient<IProcessManager>(sp => new ProcessManager(sp.GetRequiredService<ILogger<ProcessManager>>(), "git"));
+        services.TryAddTransient<ILogger>(sp => sp.GetRequiredService<ILogger<VmrManagerBase>>());
+        services.TryAddTransient<ITelemetryRecorder, NoTelemetryRecorder>();
+        services.TryAddTransient<IFileSystem, FileSystem>();
+
+        return services;
+    }
+
     private static IServiceCollection AddVmrManagers(
         IServiceCollection services,
         string gitLocation,

test/Maestro.Data.Tests/DependencyRegistrationTests.cs

@@ -28,5 +28,4 @@ public void AreDependenciesRegistered()
             },
             out var message).Should().BeTrue(message);
     }
-
 }

test/Microsoft.DotNet.DarcLib.Tests/Microsoft.DotNet.DarcLib.Tests.csproj

@@ -6,6 +6,7 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <PackageReference Include="Microsoft.DotNet.Internal.DependencyInjection.Testing" />
     <PackageReference Include="Microsoft.EntityFrameworkCore" />
     <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" />
     <PackageReference Include="Microsoft.DotNet.Internal.Testing.Utility" />

test/Microsoft.DotNet.DarcLib.Tests/VirtualMonoRepo/VmrRegistrationsTests.cs

@@ -0,0 +1,22 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using FluentAssertions;
+using Microsoft.DotNet.DarcLib.VirtualMonoRepo;
+using Microsoft.DotNet.Internal.DependencyInjection.Testing;
+using NUnit.Framework;
+
+namespace Microsoft.DotNet.DarcLib.Tests.VirtualMonoRepo;
+
+public class VmrRegistrationsTests
+{
+    /// <summary>
+    /// Tests registering of dependencies for GitNativeRepoCloner
+    /// </summary>
+    [Test]
+    public void AddGitNativeRepoClonerSupportRegistrationIsCoherent()
+    {
+        DependencyInjectionValidation.IsDependencyResolutionCoherent(sc => sc.AddGitNativeRepoClonerSupport(),
+        out var message).Should().BeTrue(message);
+    }
+}