Fails if registry item is PHP-falsey (#536)

granthony · benathomeofchampions · commit 7cf3f5832297 · 2019-06-06T13:04:21.000+01:00
register() will throw an exception if sales_order_status_before is set to any PHP-falsey value -- boolean false, empty string, etc.
diff --git a/Observer/Sales/OrderSaveBefore.php b/Observer/Sales/OrderSaveBefore.php
@@ -57,7 +57,7 @@ public function execute(\Magento\Framework\Event\Observer $observer)
             $orderStatus = $reloaded->getStatus();
         }
         //register the order status before change
-        if (!$this->registry->registry('sales_order_status_before')) {
+        if (is_null($this->registry->registry('sales_order_status_before'))) {
             $this->registry->register(
                 'sales_order_status_before',
                 $orderStatus

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ public function execute(\Magento\Framework\Event\Observer $observer)`
`57`	`57`	`$orderStatus = $reloaded->getStatus();`
`58`	`58`	`}`
`59`	`59`	`//register the order status before change`
`60`		`- if (!$this->registry->registry('sales_order_status_before')) {`
	`60`	`+ if (is_null($this->registry->registry('sales_order_status_before'))) {`
`61`	`61`	`$this->registry->register(`
`62`	`62`	`'sales_order_status_before',`
`63`	`63`	`$orderStatus`