Skip to content

Commit 17649f8

Browse files
committed
Merged PR 21305: Hotfix: Update version condition for system-alert defaults
## What's being changed The version condition for setting default user roles for system alerts needed updating to `< 4.5.2`. ## How to review / test this change - Reset config values containing `system_alerts` - Set version for our module in table to < 4.5.2 - Run upgrade - Check config table for `connector_developer_settings/system_alerts/user_roles` Related work items: #115384
1 parent b1821b5 commit 17649f8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Setup/UpgradeData.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ public function upgrade(ModuleDataSetupInterface $setup, ModuleContextInterface
158158
$this->upgradeFourOhOne($setup, $context);
159159
$this->upgradeFourThreeSix($setup, $context);
160160
$this->upgradeFourFourZero($setup, $context);
161-
$this->upgradeFourFiveOne($context);
161+
$this->upgradeFourFiveTwo($context);
162162

163163
$installer->endSetup();
164164
}
@@ -380,10 +380,10 @@ private function upgradeFourFourZero(
380380
/**
381381
* @param ModuleContextInterface $context
382382
*/
383-
private function upgradeFourFiveOne(
383+
private function upgradeFourFiveTwo(
384384
ModuleContextInterface $context
385385
) {
386-
if (version_compare($context->getVersion(), '4.5.1', '<')) {
386+
if (version_compare($context->getVersion(), '4.5.2', '<')) {
387387
if (!$this->scopeConfig->isSetFlag(Config::XML_PATH_CONNECTOR_SYSTEM_ALERTS_USER_ROLES)) {
388388
$defaultRole = $this->roleCollection->create()
389389
->setRolesFilter()

0 commit comments

Comments
 (0)