Minimize external dependencies on Linux #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormshield-guillaumed
force-pushed
the
external_dependencies
branch
from
b02d518 to
5f54ed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not change the output, I checked it by running the CI on my branch.
It would be great to minimize the use of external dependencies which are not necessary. The reason is on a system using SELinux, where you need a policy to allow the different actions of you program, the actual implementation on Linux makes you write a lot of rules to allow the execution of all the tools used.
With the refactor, you only need to allow execution of
hostnamectland read access on both files.