Merge pull request #160 from docusign/feature/pkce-auth

Add PKCE to Quick ACG

Author: InbarGazit

app/quick_acg/quick_acg_app/views.py

@@ -34,7 +34,14 @@ def ds_callback():
 
     # Save the redirect eg if present
     redirect_url = session.pop("eg", None)
-    resp = DSClient.get_token("code_grant")
+    try:
+        resp = DSClient.get_token("code_grant")
+    except Exception as err:
+        if session.get("pkce_failed", False):
+            raise err
+
+        session["pkce_failed"] = True
+        return redirect(url_for("ds.ds_login"))
 
     # app.logger.info("Authenticated with DocuSign.")
     session["ds_access_token"] = resp["access_token"]

app/quick_acg/run.py

@@ -1,19 +1,20 @@
-#!flask/bin/python
-from app.quick_acg.quick_acg_app import quick_acg_app
-from flask_session import Session
-import os
-
-quick_acg_app.config["QUICK_ACG"] = True
-
-if os.environ.get("DEBUG", False) == "True":
-    quick_acg_app.config["DEBUG"] = True
-    quick_acg_app.config['SESSION_TYPE'] = 'filesystem'
-    sess = Session()
-    sess.init_app(quick_acg_app)
-    port = int(os.environ.get("PORT", 3000))
-    quick_acg_app.run(host="localhost", port=3000, debug=True)
-else:
-    quick_acg_app.config['SESSION_TYPE'] = 'filesystem'
-    sess = Session()
-    sess.init_app(quick_acg_app)
-    quick_acg_app.run(host="localhost", port=3000, debug=True)
+#!flask/bin/python
+from app.quick_acg.quick_acg_app import quick_acg_app
+from flask_session import Session
+import os
+
+quick_acg_app.config["QUICK_ACG"] = True
+os.environ['OAUTHLIB_INSECURE_TRANSPORT'] = '1'
+
+if os.environ.get("DEBUG", False) == "True":
+    quick_acg_app.config["DEBUG"] = True
+    quick_acg_app.config['SESSION_TYPE'] = 'filesystem'
+    sess = Session()
+    sess.init_app(quick_acg_app)
+    port = int(os.environ.get("PORT", 3000))
+    quick_acg_app.run(host="localhost", port=3000, debug=True)
+else:
+    quick_acg_app.config['SESSION_TYPE'] = 'filesystem'
+    sess = Session()
+    sess.init_app(quick_acg_app)
+    quick_acg_app.run(host="localhost", port=3000, debug=True)