Skip to content

Commit 2736fd5

Browse files
committed
#2318 DBAL-831 adding note about possible fragile test comparing entire SQL query strings
1 parent e38feb4 commit 2736fd5

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

tests/Doctrine/Tests/DBAL/Platforms/OraclePlatformTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -712,6 +712,9 @@ public function testQuotedTableNames()
712712
*/
713713
public function testReturnsGetListTableColumnsSQL($database, $expectedSql)
714714
{
715+
// note: this assertion is a bit strict, as it compares a full SQL string.
716+
// Should this break in future, then please try to reduce the matching to substring matching while reworking
717+
// the tests
715718
$this->assertEquals($expectedSql, $this->_platform->getListTableColumnsSQL('"test"', $database));
716719
}
717720

0 commit comments

Comments
 (0)