Merge pull request #113 from docker/fix-completion-panic

Prevent completion error with empty arrays

Author: rcjsuen

CHANGELOG.md

@@ -2,6 +2,14 @@
 
 All notable changes to the Docker Language Server will be documented in this file.
 
+## [0.4.1] - 2025-04-29
+
+### Fixed
+
+- Compose
+  - textDocument/completion
+    - protect the completion calculation code from throwing errors when encountering empty array items ([#112](https://github.com/docker/docker-language-server/issues/112))
+
 ## [0.4.0] - 2025-04-28
 
 ### Added

internal/compose/completion.go

@@ -164,10 +164,7 @@ func walkNodes(line int, nodes []*yaml.Node) ([]*yaml.Node, *yaml.Node) {
 			if nodes[i].Kind == yaml.MappingNode {
 				return walkNodes(line, nodes[i].Content)
 			}
-			if len(nodes) == 1 {
-				return []*yaml.Node{nodes[i]}, nil
-			}
-			return []*yaml.Node{nodes[i]}, nodes[i+1]
+			return []*yaml.Node{nodes[i]}, nil
 		} else if line < nodes[i].Line {
 			break
 		}

internal/compose/completion_test.go

@@ -1598,6 +1598,17 @@ services:
 			character: 22,
 			list:      nil,
 		},
+		{
+			name: "bug",
+			content: `
+networks:
+- 
+- 
+- `,
+			line:      4,
+			character: 2,
+			list:      nil,
+		},
 	}
 
 	composeFileURI := fmt.Sprintf("file:///%v", strings.TrimPrefix(filepath.ToSlash(filepath.Join(os.TempDir(), "compose.yaml")), "/"))