Keep generic tool previews responsive while they stream - #199
Merged
Merged
Conversation
When pi streams a generic tool call, Emacs used to rebuild the growing JSON argument header on every small update. Large subagent or extension calls could make the chat buffer pause while the call was still only a preview. Show just the generic tool name during that live phase, then restore the full arguments when the tool call finishes streaming or execution starts with authoritative arguments. Built-in tools keep their compact streaming headers, so bash commands and file paths still appear as soon as pi knows them. Handle each streaming tool call by its content index, so completing one preview does not force neighboring previews to reveal partial arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pi streams a generic tool call, Emacs used to rebuild the growing
JSON argument header on every small update. Large subagent or extension
calls could make the chat buffer pause while the call was still only a
preview.
Show just the generic tool name during that live phase, then restore the
full arguments when the tool call finishes streaming or execution starts
with authoritative arguments. Built-in tools keep their compact streaming
headers, so bash commands and file paths still appear as soon as pi knows
them.
Handle each streaming tool call by its content index, so completing one
preview does not force neighboring previews to reveal partial arguments.