Skip to content

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented Nov 22, 2025

Note that is(X == function) is only true when X is a function type, so the docs here were misleading (e.g. implying that passes function pointers).
Remove unnecessary T identifier in implementation.
Add tests.

Note that `is(X == function)` is only true when X is a function type,
so the docs here were misleading.
Remove unnecessary `T` identifier in implementation.
Add tests.
@ntrel ntrel requested a review from PetarKirov as a code owner November 22, 2025 11:30
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10904"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

@thewilsonator thewilsonator merged commit 999b129 into dlang:master Nov 22, 2025
9 of 10 checks passed
@ntrel ntrel deleted the isFunction branch November 22, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants