Merge pull request #110 from diondokter/compile-time-explosion

Compile time explosion & 1.0.7

Author: diondokter

CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ### Unreleased
 
+### 1.0.7 (30-07-25)
+
+- Fix a compilation time explosion issue. The generated `read_all_registers` functions have been simplified.
+  On devices with many registers, the async variant would explode in compilation time because of the many awaits.
+  The callback name parameter now doesn't include the index anymore for repeated registers.
+  https://github.com/rust-lang/rust/issues/144635
+
 ### 1.0.6 (18-06-25)
 
 - Fixed regression introduced in 1.0.3 where signed integers were not sign-extended

Cargo.toml

@@ -9,7 +9,7 @@ members = [
     "tests",
 ]
 
-package.version = "1.0.6"
+package.version = "1.0.7"
 package.authors = ["Dion Dokter <[email protected]>"]
 package.license = "MIT OR Apache-2.0"
 package.homepage = "https://github.com/diondokter/device-driver"

cli/Cargo.toml

@@ -15,5 +15,5 @@ default-run = "device-driver-cli"
 [dependencies]
 anyhow = "1.0.98"
 clap = { version = "4.5.20", features = ["derive"] }
-device-driver-generation = { version = "=1.0.6", path = "../generation" }
+device-driver-generation = { version = "=1.0.7", path = "../generation" }
 syn = { version = "2.0" }

device-driver/Cargo.toml

@@ -12,7 +12,7 @@ description = "A toolkit to write better device drivers, faster"
 readme = "README.md"
 
 [dependencies]
-device-driver-macros = { version = "=1.0.6", path = "../macros", default-features = false, optional = true }
+device-driver-macros = { version = "=1.0.7", path = "../macros", default-features = false, optional = true }
 
 embedded-io = "0.6.1"
 embedded-io-async = "0.6.1"

generation/templates/rust/block.rs.j2

@@ -76,12 +76,11 @@ impl{{block_generics}} {{ block.name }}{{block_generics}} {
                             callback({{method.address}} + 0 * 0, "{{method.name}}", reg.into());
                         {% endwhen %}
                         {% when BlockMethodKind::Repeated { count, stride } %}
-                            {% for index in 0..*count %}
-                                {{method.cfg_attr}}
-                                let reg = self.{{method.name}}({{index}}).read()?;
-                                {{method.cfg_attr}}
-                                callback({{method.address}} + {{index}} * {{stride}}, "{{method.name}}[{{index}}]", reg.into());
-                            {% endfor %}
+                            {{method.cfg_attr}}
+                            for index in 0..{{count}} {
+                                let reg = self.{{method.name}}(index).read()?;
+                                callback({{method.address}} + index as {{device.register_address_type}} * {{stride}}, "{{method.name}}", reg.into());
+                            }
                         {% endwhen %}
                     {% endmatch %}
                 {% endif %}
@@ -124,12 +123,11 @@ impl{{block_generics}} {{ block.name }}{{block_generics}} {
                             callback({{method.address}} + 0 * 0, "{{method.name}}", reg.into());
                         {% endwhen %}
                         {% when BlockMethodKind::Repeated { count, stride } %}
-                            {% for index in 0..*count %}
-                                {{method.cfg_attr}}
-                                let reg = self.{{method.name}}({{index}}).read_async().await?;
-                                {{method.cfg_attr}}
-                                callback({{method.address}} + {{index}} * {{stride}}, "{{method.name}}[{{index}}]", reg.into());
-                            {% endfor %}
+                            {{method.cfg_attr}}
+                            for index in 0..{{count}} {
+                                let reg = self.{{method.name}}(index).read_async().await?;
+                                callback({{method.address}} + index as {{device.register_address_type}} * {{stride}}, "{{method.name}}", reg.into());
+                            }
                         {% endwhen %}
                     {% endmatch %}
                 {% endif %}

macros/Cargo.toml

@@ -16,7 +16,7 @@ readme = "README.md"
 proc-macro = true
 
 [dependencies]
-device-driver-generation = { version = "=1.0.6", path = "../generation", default-features = false }
+device-driver-generation = { version = "=1.0.7", path = "../generation", default-features = false }
 syn = { version = "2.0" }
 proc-macro2 = "1.0"