From 032b7c6b1b9ab52be72cc53f3934aff4f24e47ef Mon Sep 17 00:00:00 2001 From: Chad Sheets Date: Sat, 20 May 2017 11:17:14 -0700 Subject: [PATCH 1/2] updated element-resize-event --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 5899abb..0cab422 100644 --- a/package.json +++ b/package.json @@ -49,7 +49,7 @@ "react-dom": "^0.14.0 || ^15.0.0" }, "dependencies": { - "element-resize-event": "^2.0.4", + "element-resize-event": "^2.0.8", "lodash.debounce": "^4.0.6" } } From 0c0b4f7b71fe66d1ed33f4bf4cc393b85aed233e Mon Sep 17 00:00:00 2001 From: Chad Sheets Date: Sat, 20 May 2017 11:26:12 -0700 Subject: [PATCH 2/2] unbind event listener --- index.jsx | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/index.jsx b/index.jsx index 35f3ae5..5dd632b 100644 --- a/index.jsx +++ b/index.jsx @@ -1,6 +1,7 @@ const _debounce = require('lodash.debounce') const React = require('react') const onElementResize = require('element-resize-event') +const unbind = require('element-resize-event').unbind function defaultGetDimensions (element) { return [element.clientWidth, element.clientHeight] @@ -139,9 +140,12 @@ module.exports = function Dimensions ({ } componentWillUnmount () { - this.getWindow().removeEventListener('resize', this.onResize) - // TODO: remote element-resize-event listener. - // pending https://github.com/KyleAMathews/element-resize-event/issues/2 + this._parent = this.refs.wrapper.parentNode + if (elementResize) { + unbind(this._parent) + } else { + this.getWindow().removeEventListener('resize', this.onResize) + } } /**