Skip to content

Require smpq for CPACK on non-Apple platforms #8293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2025
Merged

Require smpq for CPACK on non-Apple platforms #8293

merged 1 commit into from
Nov 29, 2025
+3 −3

Conversation

@skypher
Copy link
Contributor

@skypher skypher commented Nov 29, 2025

Summary

  • Packaging was silently producing incomplete packages when smpq was missing on Windows and Linux
  • Now CMake configuration fails with a clear error instead of building a package without the MPQ file

Test plan

  • Configure with CPACK=ON without smpq installed on Linux/Windows - should fail
  • Configure with CPACK=ON with smpq installed - should succeed
  • Apple builds unaffected (they don't include the MPQ in the DMG)
  • Console builds (Switch, Vita, etc.) unaffected (they don't use CPack)

@skypher
Require smpq for CPACK on non-Apple platforms
d59edc7 
DLL packaging was silently producing incomplete packages when smpq was
missing. Now CMake configuration fails with a clear error instead.
@AJenbo AJenbo enabled auto-merge (rebase) November 29, 2025 10:10
@AJenbo AJenbo merged commit 17edf8c into diasurgical:master Nov 29, 2025
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AJenbo AJenbo AJenbo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skypher @AJenbo