Skip to content

Commit ec5b356

Browse files
committed
docs: correct misleading 'hermetic' framing on ZSTD_MULTITHREAD off
zig bundles pthreads for every target regardless of this flag, so nothing hermeticity-related is being avoided by leaving it off. The real consequence is that ZstdCompressParameter's NB_WORKERS becomes a silent no-op at the C level - a functional gap, not a build detail. Whether to flip it on is deferred to #80; this just fixes the comment so it stops describing an incorrect rationale.
1 parent 65f48f7 commit ec5b356

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

scripts/build-zstd.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,11 @@ WORK="$(mktemp -d)"
9595
trap 'rm -rf "$WORK"' EXIT
9696

9797
# Compile flags:
98-
# -DZSTD_MULTITHREAD off -> single-threaded, no pthread dependency (hermetic)
98+
# -DZSTD_MULTITHREAD off -> single-threaded. NOT a hermeticity choice - zig
99+
# bundles pthreads for every target regardless.
100+
# Left off for now (undecided, not evaluated on
101+
# the merits); this makes ZstdCompressParameter's
102+
# NB_WORKERS a silent no-op. See #80.
99103
# -DXXH_NAMESPACE -> matches zstd's own build, avoids xxhash symbol clashes
100104
# ELF/Mach-O: -fvisibility=hidden + zstd's ZSTDLIB_VISIBLE keeps the surface
101105
# minimal. Windows/MinGW: drop hidden visibility and let lld auto-export every

0 commit comments

Comments
 (0)