Skip to content

Only pass --ignore-addr-diffs to asm-differ for aarch64 #2099

Description

@simonlindholm

For arm32, --ignore-addr-diffs is harmful, because it silences diffs in bl symbol names. (simonlindholm/asm-differ#225)

For aarch64, it is helpful because the typical workflow diffs linked files against unlinked ones, and then addr diffs are expected to be ignored.

For all other architectures, the flag is unimplemented by asm-differ.

The argument gets passed here:

ignore_addr_diffs=True,

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions