Add hashcash in components controllers (#428)

* add hashcash hidden file in components controllers

* Update app/controllers/concerns/decidim/decidim_awesome/needs_hashcash.rb

Co-authored-by: Ivan Vergés <[email protected]>

* add _login_modal partial to checksum

* fix test of number of override files

---------

Co-authored-by: Ivan Vergés <[email protected]>

Author: davidbeig

app/controllers/concerns/decidim/decidim_awesome/needs_hashcash.rb

@@ -30,11 +30,11 @@ def awesome_check_hashcash
 
       # Dynamically configures the gem https://github.com/BaseSecrete/active_hashcash
       def set_hashcash_bits
-        if controller_name == "sessions"
-          ActiveHashcash.bits = awesome_hashcash_bits(:login)
-        elsif controller_name == "registrations"
-          ActiveHashcash.bits = awesome_hashcash_bits(:signup)
-        end
+        ActiveHashcash.bits = if controller_name == "registrations"
+                                awesome_hashcash_bits(:signup)
+                              else
+                                awesome_hashcash_bits(:login)
+                              end
       end
     end
   end

app/overrides/decidim/shared/_login_modal/add_hashcash.html.erb.deface

@@ -0,0 +1,3 @@
+<!-- insert_after "erb[loud]:contains('sign_up')" -->
+
+<%= render partial: "decidim/decidim_awesome/hashcash/hidden_field", locals: { zone: :login } %>

lib/decidim/decidim_awesome/checksums.yml

@@ -34,6 +34,8 @@ decidim-core:
     decidim-0.29.1: b30423406afd43bb9af2c98d59d43632
   /app/views/decidim/devise/sessions/new.html.erb:
     decidim-0.29.1: a8fe60cd10c1636822c252d5488a979d
+  /app/views/decidim/shared/_login_modal.html.erb:
+    decidim-0.29.1: 0d615603bb45f7b209032578dda9fc72
 decidim-proposals:
   /lib/decidim/proposals/proposal_serializer.rb:
     decidim-0.29.1: 58915ff3a7528463587d3762a93ff51b

lib/decidim/decidim_awesome/engine.rb

@@ -30,6 +30,7 @@ class Engine < ::Rails::Engine
           # Add hashcash to signup and login
           Decidim::Devise::SessionsController.include(Decidim::DecidimAwesome::NeedsHashcash)
           Decidim::Devise::RegistrationsController.include(Decidim::DecidimAwesome::NeedsHashcash)
+          Decidim::Components::BaseController.include(Decidim::DecidimAwesome::NeedsHashcash)
         end
         # Include additional helpers globally
         ActiveSupport.on_load(:action_view) { include Decidim::DecidimAwesome::AwesomeHelpers }

spec/lib/system_checker_spec.rb

@@ -16,8 +16,8 @@ module Decidim::DecidimAwesome
       expect(subject.overrides["decidim-admin"].files.length).to eq(1)
     end
 
-    it "has 13 modified files in core" do
-      expect(subject.overrides["decidim-core"].files.length).to eq(15)
+    it "has 16 modified files in core" do
+      expect(subject.overrides["decidim-core"].files.length).to eq(16)
     end
 
     it "has 18 modified files in proposals" do