Refactored reply structure to a RecordsRead #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehenrytsai
requested review from
LiranCohen,
csuwildcat and
mistermoe
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 74 74
Lines 11508 11509 +1
Branches 1661 1661
=======================================
+ Hits 11361 11362 +1
Misses 141 141
Partials 6 6 ☔ View full report in Codecov by Sentry. |
csuwildcat
previously approved these changes
Oct 4, 2024
LiranCohen
previously approved these changes
Oct 7, 2024
Member
LiranCohen
left a comment
LiranCohen
left a comment
There was a problem hiding this comment.
🐐 🐐 🐐 🚀 🚀 🚀
🙏 This is already much cleaner!
Just a small nit.
thehenrytsai
dismissed stale reviews from LiranCohen and csuwildcat
via
8ea1f0a
LiranCohen
approved these changes
Oct 7, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the reply structure of a
RecordsReadis quite messy: (duplicated properties, data stream nested in a message, inconsistent naming etc).This is an attempt at cleaning it up with a flatter structure.