Skip to content

Commit 42ee712

Browse files
committed
fix: fix guidelines when dragging
1 parent 32d634c commit 42ee712

File tree

13 files changed

+57
-39
lines changed

13 files changed

+57
-39
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.
33

44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
55

6+
## [0.10.1] - 2019-11-12
7+
### Fixed
8+
* Fix that guidelines do not appear when dragging.
9+
610
## [0.10.0] - 2019-11-09
711
### Added
812
* Add `scrollable` props. #39

package-lock.json

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "moveable",
3-
"version": "0.10.0",
3+
"version": "0.10.1",
44
"description": "Moveable is Draggable, Resizable, Scalable, Rotatable, Warpable, Pinchable, Groupable, Snappable.",
55
"main": "./dist/moveable.cjs.js",
66
"module": "./dist/moveable.esm.js",
@@ -55,7 +55,7 @@
5555
"homepage": "https://github.com/daybrush/moveable#readme",
5656
"dependencies": {
5757
"@egjs/component": "^2.1.2",
58-
"preact-moveable": "^0.12.6"
58+
"preact-moveable": "^0.12.7"
5959
},
6060
"devDependencies": {
6161
"@daybrush/builder": "^0.1.2",

packages/preact-moveable/package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/preact-moveable/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "preact-moveable",
3-
"version": "0.12.6",
3+
"version": "0.12.7",
44
"description": "A Preact Component that create Moveable, Draggable, Resizable, Scalable, Rotatable, Pinchable, Groupable, Snappable.",
55
"main": "./dist/moveable.cjs.js",
66
"module": "./dist/moveable.esm.js",
@@ -62,6 +62,6 @@
6262
"dependencies": {
6363
"preact-compat": "^3.0.0",
6464
"preact-css-styler": "^0.4.1",
65-
"react-moveable": "^0.13.6"
65+
"react-moveable": "^0.13.7"
6666
}
6767
}

packages/react-moveable/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-moveable/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-moveable",
3-
"version": "0.13.6",
3+
"version": "0.13.7",
44
"description": "A React Component that create Moveable, Draggable, Resizable, Scalable, Rotatable, Warpable, Pinchable, Groupable.",
55
"main": "./dist/moveable.cjs.js",
66
"module": "./dist/moveable.esm.js",

packages/react-moveable/src/App.tsx

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,20 +57,29 @@ class App extends React.Component {
5757
// keepRatio={false}
5858
target={this.state.targets}
5959
origin={true}
60-
// snappable={true}
61-
verticalGuidelines={[100.5, 200.5, 400, 500]}
60+
snappable={true}
61+
verticalGuidelines={[100, 200, 400, 500]}
6262
horizontalGuidelines={[100, 200, 400, 500]}
6363
throttleRotate={30}
6464
onDragGroupStart={e => {
6565
console.log("start", e);
66+
67+
e.events.forEach(ev => {
68+
const groupItem = this.itemMap.get(ev.target)!;
69+
70+
ev.set([
71+
parseFloat(groupItem.get("tx")),
72+
parseFloat(groupItem.get("ty")),
73+
]);
74+
});
6675
}}
6776
onDragGroup={e => {
6877
// console.log(e.beforeDelta);
6978

7079
e.events.forEach(ev => {
7180
const groupItem = this.itemMap.get(ev.target)!;
72-
groupItem.set("tx", `${parseFloat(groupItem.get("tx")) + ev.beforeDelta[0]}px`);
73-
groupItem.set("ty", `${parseFloat(groupItem.get("ty")) + ev.beforeDelta[1]}px`);
81+
groupItem.set("tx", `${ev.beforeTranslate[0]}px`);
82+
groupItem.set("ty", `${ev.beforeTranslate[1]}px`);
7483

7584
ev.target.style.cssText += groupItem.toCSS();
7685
});
@@ -158,7 +167,7 @@ class App extends React.Component {
158167
// renderDirections={["n", "ne", "nw"]}
159168
elementGuidelines={[document.querySelector(".box1 span")!, document.querySelector(".emo img")!]}
160169
snapCenter={false}
161-
snapThreshold={10}
170+
// snapThreshold={10}
162171
// scalable={!isResizable}
163172
// scalable={true}
164173
resizable={isResizable}

packages/react-moveable/src/react-moveable/MoveableGroup.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ class MoveableGroup extends MoveableManager<GroupableProps, any> {
151151
state.width = width;
152152
state.height = height;
153153

154-
const info = getTargetInfo(target, this.controlBox.getElement(), state);
154+
const info = getTargetInfo(target, this.controlBox.getElement(), this.getContainer(), state);
155155
const pos = [info.left!, info.top!];
156156
[
157157
info.pos1,

packages/react-moveable/src/react-moveable/MoveableManager.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,9 @@ export default class MoveableManager<T = {}, U = {}>
142142
const parentMoveable = this.props.parentMoveable;
143143
const state = this.state;
144144
const target = (state.target || this.props.target) as HTMLElement | SVGElement;
145-
145+
const container = this.getContainer();
146146
this.updateState(
147-
getTargetInfo(target, this.getContainer(), isTarget ? state : undefined),
147+
getTargetInfo(target, container, container, isTarget ? state : undefined),
148148
parentMoveable ? false : isSetState,
149149
);
150150
}

0 commit comments

Comments
 (0)