Skip to content

removed metadata_modal feature flag and related references to it #5965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwnoble merged 10 commits into from
Feb 6, 2026
Merged

removed metadata_modal feature flag and related references to it #5965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2561465
removed metadata_modal feature flag and related references to it
dwnoble Feb 4, 2026
4c6b69f
added feature flags back in
dwnoble Feb 5, 2026
1db0aab
Merge branch 'master' of github.com:datacommonsorg/website into remov…
dwnoble Feb 5, 2026
183f3ff
Merge branch 'master' into remove-metadata-modal-feature-flag
dwnoble Feb 5, 2026
c5b6411
removed duplicate feature flag
dwnoble Feb 5, 2026
16484d7
Merge branch 'remove-metadata-modal-feature-flag' of github.com:dwnob…
dwnoble Feb 5, 2026
8ccd288
Merge branch 'master' of github.com:datacommonsorg/website into remov…
dwnoble Feb 5, 2026
fb47d02
updated snapshots
dwnoble Feb 5, 2026
c4c1c3d
test fix
dwnoble Feb 5, 2026
46e6c32
Merge branch 'master' into remove-metadata-modal-feature-flag
dwnoble Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/feature_flags.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@ For example, to enable the "autocomplete" feature:
* Enable: https://datacommons.org/explore?enable_feature=autocomplete
To enable both the autocomplete and metadata_modal features:
To enable both the autocomplete and page_overview_ga features:
* Enable: https://datacommons.org/explore?enable_feature=autocomplete&enable_feature=metadata_modal
* Enable: https://datacommons.org/explore?enable_feature=autocomplete&enable_feature=page_overview_ga
To manually disable a feature flag, use the `disable_feature` URL parameter.
Expand Down
6 changes: 1 addition & 5 deletions static/js/components/subject_page/block.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ import {
FacetSelector,
FacetSelectorFacetInfo,
} from "../../shared/facet_selector/facet_selector";
import {
isFeatureEnabled,
METADATA_FEATURE_FLAG,
} from "../../shared/feature_flags/util";
import { usePromiseResolver } from "../../shared/hooks/promise_resolver";
import { NamedPlace, NamedTypedPlace, StatVarSpec } from "../../shared/types";
import {
Expand Down Expand Up @@ -246,7 +242,7 @@ function blockEligibleForFacetSelector(
columns: ColumnConfig[],
isWebComponentBlock: boolean
): boolean {
if (isWebComponentBlock || !isFeatureEnabled(METADATA_FEATURE_FLAG)) {
if (isWebComponentBlock) {
return false;
}

Expand Down
25 changes: 10 additions & 15 deletions static/js/components/tiles/chart_footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ import React, { RefObject, useState } from "react";

import { intl } from "../../i18n/i18n";
import { messages } from "../../i18n/i18n_messages";
import {
isFeatureEnabled,
METADATA_FEATURE_FLAG,
} from "../../shared/feature_flags/util";
import {
GA_EVENT_TILE_DOWNLOAD,
GA_EVENT_TILE_EXPLORE_MORE,
Expand Down Expand Up @@ -99,17 +95,16 @@ export function ChartFooter(props: ChartFooterPropType): JSX.Element {
</div>
)}

{props.getObservationSpecs &&
isFeatureEnabled(METADATA_FEATURE_FLAG) && (
<div className="outlink-item api-outlink">
<ApiButton
apiRoot={props.apiRoot}
getObservationSpecs={props.getObservationSpecs}
containerRef={props.containerRef}
surface={props.surface}
/>
</div>
)}
{props.getObservationSpecs && (
<div className="outlink-item api-outlink">
<ApiButton
apiRoot={props.apiRoot}
getObservationSpecs={props.getObservationSpecs}
containerRef={props.containerRef}
surface={props.surface}
/>
</div>
)}

{props.exploreLink && (
<div className="outlink-item explore-in-outlink">
Expand Down
2 changes: 1 addition & 1 deletion static/js/shared/facet_selector/facet_option_content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import { facetSelectionComponentMessages } from "../../i18n/i18n_facet_selection
import { metadataComponentMessages } from "../../i18n/i18n_metadata_messages";
import { humanizeIsoDuration } from "../periodicity";
import { StatMetadata } from "../stat_types";
import { SELECTOR_PREFIX } from "./facet_selector_rich";
import { SELECTOR_PREFIX } from "./facet_selector";

interface FacetOptionContentProps {
// The metadata for the facet.
Expand Down
Loading
Loading