fetch_dcids_by_wikidata_id improvement (#227)

- Renames `.fetch_dcid_by_wikidata_id` to `fetch_dcids_by_wikidata_id`
to clarify lists are accepted.
- Adds a test for lists of `wikidata_ids`

Author: jm-rivera

datacommons_client/endpoints/resolve.py

@@ -81,25 +81,25 @@ def fetch_dcids_by_name(self,
 
     return self.fetch(node_ids=names, expression=expression)
 
-  def fetch_dcid_by_wikidata_id(
+  def fetch_dcids_by_wikidata_id(
       self,
-      wikidata_id: str | list[str],
+      wikidata_ids: str | list[str],
       entity_type: Optional[str] = None) -> ResolveResponse:
     """
-        Fetches DCIDs for entities by their Wikidata IDs.
+          Fetches DCIDs for entities by their Wikidata IDs.
 
-        Args:
-            wikidata_id (str | list[str]): One or more Wikidata IDs to resolve.
-            entity_type (Optional[str]): Optional type of the entities.
+          Args:
+              wikidata_ids (str | list[str]): One or more Wikidata IDs to resolve.
+              entity_type (Optional[str]): Optional type of the entities.
 
-        Returns:
-            ResolveResponse: The response object containing the resolved DCIDs.
-        """
+          Returns:
+              ResolveResponse: The response object containing the resolved DCIDs.
+          """
     expression = _resolve_correspondence_expression(from_type="wikidataId",
                                                     to_type="dcid",
                                                     entity_type=entity_type)
 
-    return self.fetch(node_ids=wikidata_id, expression=expression)
+    return self.fetch(node_ids=wikidata_ids, expression=expression)
 
   def fetch_dcid_by_coordinates(
       self,

datacommons_client/tests/endpoints/test_resolve_endpoint.py

@@ -52,8 +52,8 @@ def test_fetch_dcid_by_wikidata_id():
   api_mock = MagicMock(spec=API)
   endpoint = ResolveEndpoint(api=api_mock)
 
-  response = endpoint.fetch_dcid_by_wikidata_id(wikidata_id="Q12345",
-                                                entity_type="Country")
+  response = endpoint.fetch_dcids_by_wikidata_id(wikidata_ids="Q12345",
+                                                 entity_type="Country")
 
   # Check the response
   assert isinstance(response, ResolveResponse)
@@ -68,6 +68,27 @@ def test_fetch_dcid_by_wikidata_id():
                                         next_token=None)
 
 
+def test_fetch_dcids_list_by_wikidata_id():
+  """Tests the fetch_dcid_by_wikidata_id method."""
+  api_mock = MagicMock(spec=API)
+  endpoint = ResolveEndpoint(api=api_mock)
+
+  response = endpoint.fetch_dcids_by_wikidata_id(
+      wikidata_ids=["Q12345", "Q695660"])
+
+  # Check the response
+  assert isinstance(response, ResolveResponse)
+
+  # Check the post request
+  api_mock.post.assert_called_once_with(payload={
+      "nodes": ["Q12345", "Q695660"],
+      "property": "<-wikidataId->dcid",
+  },
+                                        endpoint="resolve",
+                                        all_pages=True,
+                                        next_token=None)
+
+
 def test_fetch_dcid_by_coordinates():
   """Tests the fetch_dcid_by_coordinates method."""
   api_mock = MagicMock(spec=API)