lint: update circular dependencies allowlist, minor cleanup

Author: kwvg

src/llmq/ehf_signals.cpp

@@ -15,8 +15,6 @@
 #include <validation.h>
 
 namespace llmq {
-
-
 CEHFSignalsHandler::CEHFSignalsHandler(ChainstateManager& chainman, CMNHFManager& mnhfman, CSigningManager& sigman,
                                        CSigSharesManager& shareman, const CQuorumManager& qman) :
     m_chainman(chainman),
@@ -28,7 +26,6 @@ CEHFSignalsHandler::CEHFSignalsHandler(ChainstateManager& chainman, CMNHFManager
     sigman.RegisterRecoveredSigsListener(this);
 }
 
-
 CEHFSignalsHandler::~CEHFSignalsHandler()
 {
     sigman.UnregisterRecoveredSigsListener(this);

src/llmq/ehf_signals.h

@@ -13,8 +13,7 @@ class CBlockIndex;
 class ChainstateManager;
 class CMNHFManager;
 
-namespace llmq
-{
+namespace llmq {
 class CQuorumManager;
 class CSigSharesManager;
 class CSigningManager;
@@ -39,7 +38,6 @@ class CEHFSignalsHandler : public CRecoveredSigsListener
 
     ~CEHFSignalsHandler();
 
-
     /**
      * Since Tip is updated it could be a time to generate EHF Signal
      */
@@ -50,9 +48,7 @@ class CEHFSignalsHandler : public CRecoveredSigsListener
 
 private:
     void trySignEHFSignal(int bit, const CBlockIndex* const pindex) EXCLUSIVE_LOCKS_REQUIRED(!cs);
-
 };
-
 } // namespace llmq
 
 #endif // BITCOIN_LLMQ_EHF_SIGNALS_H

test/lint/lint-circular-dependencies.py

@@ -22,6 +22,8 @@
     "wallet/wallet -> wallet/walletdb -> wallet/wallet",
     "node/coinstats -> validation -> node/coinstats",
     # Dash
+    "active/context -> coinjoin/server -> net_processing -> active/context",
+    "coinjoin/coinjoin -> instantsend/instantsend -> net_processing -> coinjoin/context -> coinjoin/coinjoin",
     "banman -> common/bloom -> evo/assetlocktx -> llmq/quorums -> net -> banman",
     "chainlock/chainlock -> instantsend/instantsend -> chainlock/chainlock",
     "chainlock/chainlock -> instantsend/instantsend -> instantsend/signing -> chainlock/chainlock",
@@ -30,7 +32,6 @@
     "chainlock/chainlock -> validation -> evo/chainhelper -> chainlock/chainlock",
     "coinjoin/client -> net_processing -> coinjoin/client",
     "coinjoin/client -> net_processing -> coinjoin/context -> coinjoin/client",
-    "coinjoin/context -> coinjoin/server -> net_processing -> coinjoin/context",
     "coinjoin/server -> net_processing -> coinjoin/server",
     "common/bloom -> evo/assetlocktx -> llmq/quorums -> net -> common/bloom",
     "common/bloom -> evo/assetlocktx -> llmq/commitment -> evo/deterministicmns -> evo/simplifiedmns -> merkleblock -> common/bloom",