Skip to content

Commit fc3cf1a

Browse files
committed
Fixing missing overrides and adding one missing enum value
1 parent 839b64f commit fc3cf1a

23 files changed

+88
-89
lines changed

Src/DasherCore/AlphabetManager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ namespace Dasher {
120120
virtual ~CAlphNode();
121121
///Have to call this from CAlphabetManager, and from CGroupNode on a _different_ CAlphNode, hence public...
122122
virtual std::vector<unsigned int> *GetProbInfo();
123-
virtual int ExpectedNumChildren();
123+
virtual int ExpectedNumChildren() override;
124124
private:
125125
std::vector<unsigned int> *m_pProbInfo;
126126
};

Src/DasherCore/AlternatingDirectMode.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ namespace Dasher {
1717
public:
1818
CAlternatingDirectMode(CSettingsStore* pSettingsStore, CDasherInterfaceBase *pInterface);
1919

20-
bool DecorateView(CDasherView *pView, CDasherInput *pInput);
20+
bool DecorateView(CDasherView *pView, CDasherInput *pInput) override;
2121

22-
bool GetSettings(SModuleSettings **pSettings, int *iCount);
22+
bool GetSettings(SModuleSettings **pSettings, int *iCount) override;
2323

2424
protected:
25-
void SetupBoxes();
25+
void SetupBoxes() override;
2626

2727
private:
2828
void DirectKeyDown(unsigned long iTime, int iId, CDasherView *pView, CDasherModel *pModel);

Src/DasherCore/ButtonMultiPress.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@ class CButtonMultiPress : public CDynamicButtons {
3434
public:
3535
CButtonMultiPress(CSettingsStore* pSettingsStore, CDasherInterfaceBase *pInterface, CFrameRate *pFramerate, const char *szName);
3636

37-
void Timer(unsigned long iTime, CDasherView *pView, CDasherInput *pInput, CDasherModel *pModel, CExpansionPolicy **pol);
38-
void KeyDown(unsigned long iTime, Keys::VirtualKey Key, CDasherView *pView, CDasherInput *pInput, CDasherModel *pModel);
37+
void Timer(unsigned long iTime, CDasherView *pView, CDasherInput *pInput, CDasherModel *pModel, CExpansionPolicy **pol) override;
38+
void KeyDown(unsigned long iTime, Keys::VirtualKey Key, CDasherView *pView, CDasherInput *pInput, CDasherModel *pModel) override;
3939

40-
void pause();
40+
void pause() override;
4141
protected:
4242
virtual unsigned int maxClickCount()=0;
43-
void reverse(unsigned long iTime);
44-
void run(unsigned long iTime);
43+
void reverse(unsigned long iTime) override;
44+
void run(unsigned long iTime) override;
4545

4646
private:
4747
virtual void RevertPresses(int iCount) {};

Src/DasherCore/CircleStartHandler.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
#include "StartHandler.h"
44
#include "SettingsStore.h"
5-
#include "DasherScreen.h"
65

76
/// \ingroup Start
87
/// @{
@@ -11,11 +10,11 @@ class CCircleStartHandler : public CStartHandler {
1110
public:
1211
CCircleStartHandler(CDefaultFilter *pCreator);
1312
~CCircleStartHandler();
14-
virtual bool DecorateView(CDasherView *pView);
15-
virtual void Timer(unsigned long iTime, dasherint iX, dasherint iY, CDasherView *pView);
13+
virtual bool DecorateView(CDasherView *pView) override;
14+
virtual void Timer(unsigned long iTime, dasherint iX, dasherint iY, CDasherView *pView)override;
1615
void RegisterView(CDasherView* pView);
17-
void onPause();
18-
void onRun(unsigned long iTime);
16+
void onPause() override;
17+
void onRun(unsigned long iTime) override;
1918
protected:
2019
///Time (as unix timestamp) when user entered circle; max() => already acted upon
2120
long m_iEnterTime;

Src/DasherCore/ClickFilter.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ class CClickFilter : public CStaticFilter, private CZoomAdjuster {
2323
CClickFilter(CSettingsStore* pSettingsStore, CDasherInterfaceBase *pInterface)
2424
: CStaticFilter(pSettingsStore, pInterface, _("Click Mode")) { };
2525

26-
virtual bool DecorateView(CDasherView *pView, CDasherInput *pInput);
27-
virtual void KeyDown(unsigned long iTime, Keys::VirtualKey Key, CDasherView *pView, CDasherInput *pInput, CDasherModel *pModel);
28-
virtual bool GetSettings(SModuleSettings **pSettings, int *iCount);
26+
virtual bool DecorateView(CDasherView *pView, CDasherInput *pInput) override;
27+
virtual void KeyDown(unsigned long iTime, Keys::VirtualKey Key, CDasherView *pView, CDasherInput *pInput, CDasherModel *pModel) override;
28+
virtual bool GetSettings(SModuleSettings **pSettings, int *iCount) override;
2929

3030
private:
3131
//for mouse lines

Src/DasherCore/CompassMode.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ class CCompassMode : public CDasherButtons
1616

1717
virtual void HandleEvent(Parameter parameter);
1818

19-
bool DecorateView(CDasherView *pView, CDasherInput *pInput);
19+
bool DecorateView(CDasherView *pView, CDasherInput *pInput) override;
2020

21-
bool GetSettings(SModuleSettings **pSettings, int *iCount);
21+
bool GetSettings(SModuleSettings **pSettings, int *iCount) override;
2222

2323
protected:
24-
void SetupBoxes();
24+
void SetupBoxes() override;
2525

2626
private:
2727
int iTargetWidth;

Src/DasherCore/ConvertingAlphMgr.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ namespace Dasher {
2323
public:
2424
CConvertingAlphMgr(CSettingsStore* pSettingsStore, CDasherInterfaceBase *pInterface, CNodeCreationManager *pNCManager, CConversionManager *pConvMgr, const CAlphInfo *pAlphabet);
2525
///Override to also tell the ConversionManager that the screen has changed.
26-
void MakeLabels(CDasherScreen *pScreen);
26+
void MakeLabels(CDasherScreen *pScreen) override;
2727
virtual ~CConvertingAlphMgr();
2828
protected:
2929
///Override to return a conversion root for iSymbol==(one beyond last alphabet symbol)
30-
virtual CDasherNode *CreateSymbolNode(CAlphNode *pParent, symbol iSymbol);
30+
virtual CDasherNode *CreateSymbolNode(CAlphNode *pParent, symbol iSymbol) override;
3131
private:
3232
CConversionManager *m_pConvMgr;
3333

Src/DasherCore/DasherButtons.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ class CDasherButtons : public CStaticFilter
1515
CDasherButtons(CSettingsStore* pSettingsStore, CDasherInterfaceBase *pInterface, bool bMenu, const char *szName);
1616
virtual ~CDasherButtons();
1717

18-
virtual bool DecorateView(CDasherView *pView, CDasherInput *pInput)=0;
18+
virtual bool DecorateView(CDasherView *pView, CDasherInput *pInput) override =0;
1919

20-
void KeyDown(unsigned long iTime, Keys::VirtualKey Key, CDasherView *pView, CDasherInput *pInput, CDasherModel *pModel);
21-
void Timer(unsigned long Time, CDasherView *pView, CDasherInput *pInput, CDasherModel *m_pDasherModel, CExpansionPolicy **pol);
22-
void Activate();
20+
void KeyDown(unsigned long iTime, Keys::VirtualKey Key, CDasherView *pView, CDasherInput *pInput, CDasherModel *pModel) override;
21+
void Timer(unsigned long Time, CDasherView *pView, CDasherInput *pInput, CDasherModel *m_pDasherModel, CExpansionPolicy **pol) override;
22+
void Activate() override;
2323

2424
struct SBoxInfo {
2525
int iTop;

Src/DasherCore/DefaultFilter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ double xmax(double y)
294294
void CDefaultFilter::ApplyTransform(myint& iDasherX, myint& iDasherY, CDasherView* pView)
295295
{
296296
ApplyOffset(iDasherX, iDasherY);
297-
if (m_pSettingsStore->GetLongParameter(LP_GEOMETRY) == 1)
297+
if (m_pSettingsStore->GetLongParameter(LP_GEOMETRY) == Options::ScreenGeometry::square_no_xhair)
298298
{
299299
//crosshair may be offscreen; so do something to allow us to navigate
300300
// up/down and reverse

Src/DasherCore/DemoFilter.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ class CDemoFilter : public CDynamicFilter {
1212

1313
virtual void HandleEvent(Parameter parameter);
1414

15-
virtual bool DecorateView(CDasherView *pView, CDasherInput *pInput);
16-
virtual void Timer(unsigned long Time, CDasherView *m_pDasherView, CDasherInput *pInput, CDasherModel *m_pDasherModel, CExpansionPolicy **pol);
17-
virtual void KeyDown(unsigned long iTime, Keys::VirtualKey Key, CDasherView *pDasherView, CDasherInput *pInput, CDasherModel *pModel);
18-
virtual void Activate();
19-
virtual void Deactivate();
15+
virtual bool DecorateView(CDasherView *pView, CDasherInput *pInput) override;
16+
virtual void Timer(unsigned long Time, CDasherView *m_pDasherView, CDasherInput *pInput, CDasherModel *m_pDasherModel, CExpansionPolicy **pol) override;
17+
virtual void KeyDown(unsigned long iTime, Keys::VirtualKey Key, CDasherView *pDasherView, CDasherInput *pInput, CDasherModel *pModel) override;
18+
virtual void Activate() override;
19+
virtual void Deactivate() override;
2020
private:
2121
double m_dSpring, m_dNoiseNew, m_dNoiseOld;
2222
double m_dNoiseX, m_dNoiseY;

0 commit comments

Comments
 (0)