Skip to content

period as optional parameter to retrieve 5 min, 15min, etc. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flamby wants to merge 1 commit into
base: master
Choose a base branch
from
Open

period as optional parameter to retrieve 5 min, 15min, etc. #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cryptory/cryptory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def extract_bitinfocharts(self, coin, metric="price", coin_col=False, metric_col
output['metric'] = metric
return output.sort_values(by='date', ascending=self.ascending).reset_index(drop=True)

def extract_poloniex(self, coin1, coin2, coin1_col=False, coin2_col=False):
def extract_poloniex(self, coin1, coin2, coin1_col=False, coin2_col=False, period=None):
"""Retrieve the historical price of one coin relative to another (currency pair) from poloniex

Parameters
Expand All @@ -214,16 +214,17 @@ def extract_poloniex(self, coin1, coin2, coin1_col=False, coin2_col=False):
(default is False i.e. the column is not included)
coin2_col : whether to include the coin2 code as a column
(default is False i.e. the column is not included)
period : optional parameter, period in seconds (default is 86400 aka 1 day) choices are [300, 900, 1800, 7200, 14400, 86400] according to poloniex api documentation

Returns
-------
pandas Dataframe
"""
if period is None: period = 86400
from_date = int(time.mktime(time.strptime(self.from_date, "%Y-%m-%d")))
to_date = int(time.mktime(time.strptime(self.to_date, "%Y-%m-%d")))
url = "https://poloniex.com/public?command=returnChartData&currencyPair={}_{}&start={}&end={}&period=86400".format(
coin1.upper(), coin2.upper(), from_date, to_date)
url = "https://poloniex.com/public?command=returnChartData&currencyPair={}_{}&start={}&end={}&period={}".format(
coin1.upper(), coin2.upper(), from_date, to_date, period)
try:
parsed_page = urlopen(url, timeout=self.timeout).read()
parsed_page = parsed_page.decode("utf8")
Expand Down