Skip to content

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Sep 19, 2025

Small refactoring to ensure hot reload isn't mentioned as VM only

Fixes

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn't use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

@mit-mit
Copy link
Member Author

mit-mit commented Sep 19, 2025

@vsmenon did I get all the places (I could not find the exact text you had in the issue in search)?

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit fdcb235):

https://dart-dev--pr6884-reload-tfodpd6z.web.app

@mit-mit
Copy link
Member Author

mit-mit commented Sep 19, 2025

Oh, found the text "with Dart VMs instant hot reload"; it's in the video at the top of https://dart.dev

I don't think we have "source" for that video. But I was wondering if we still think that video is important, of we should simplify the landing page a bit, and just drop it? Thoughts @redbrogdon @vsmenon ?


* An incremental JavaScript development compiler enabling a fast developer
cycle.
cycle with incremental recompilation (enabling hot reload).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text within the sentence is a bit redundant. Perhaps just "An incremental JavaScript development compiler enabling a fast iteration cycle with stateful hot reload."?

@vsmenon
Copy link
Member

vsmenon commented Sep 19, 2025

It's a nice video, but I favor accuracy. I think it'd be fine to drop / simplify.

@mit-mit mit-mit merged commit 0672cee into main Sep 22, 2025
11 checks passed
@mit-mit mit-mit deleted the reload branch September 22, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix hot reload message to be non-VM specific
4 participants