rename "warnings" to something more distinct internally #1901
Description
@gspencergoog pointed out that it is confusing to have warnings that are errors and errors that are warnings. The analyzer is not much better as it calls them "errors" internally where we call them "warnings".