Skip to content

Conversation

@salaboy
Copy link
Collaborator

@salaboy salaboy commented Dec 5, 2025

Description

Promoted Jobs API to DaprClient. Updated example too.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1594

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@salaboy salaboy requested review from a team as code owners December 5, 2025 09:29
@salaboy salaboy self-assigned this Dec 5, 2025
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are compilation errors that need fixing from this PR - mind taking a look?

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:testCompile (default-testCompile) on project dapr-sdk-tests: Compilation failure: Compilation failure: 
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[101,22] cannot find symbol
Error:    symbol:   method scheduleJob(io.dapr.client.domain.ScheduleJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[104,26] cannot find symbol
Error:    symbol:   method getJob(io.dapr.client.domain.GetJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[106,22] cannot find symbol
Error:    symbol:   method deleteJob(io.dapr.client.domain.DeleteJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[118,22] cannot find symbol
Error:    symbol:   method scheduleJob(io.dapr.client.domain.ScheduleJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[122,26] cannot find symbol
Error:    symbol:   method getJob(io.dapr.client.domain.GetJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[124,22] cannot find symbol
Error:    symbol:   method deleteJob(io.dapr.client.domain.DeleteJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[139,22] cannot find symbol
Error:    symbol:   method scheduleJob(io.dapr.client.domain.ScheduleJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[147,26] cannot find symbol
Error:    symbol:   method getJob(io.dapr.client.domain.GetJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[149,22] cannot find symbol
Error:    symbol:   method deleteJob(io.dapr.client.domain.DeleteJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[168,22] cannot find symbol
Error:    symbol:   method scheduleJob(io.dapr.client.domain.ScheduleJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[176,26] cannot find symbol
Error:    symbol:   method getJob(io.dapr.client.domain.GetJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[178,22] cannot find symbol
Error:    symbol:   method deleteJob(io.dapr.client.domain.DeleteJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[191,22] cannot find symbol
Error:    symbol:   method scheduleJob(io.dapr.client.domain.ScheduleJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[200,26] cannot find symbol
Error:    symbol:   method getJob(io.dapr.client.domain.GetJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[202,22] cannot find symbol
Error:    symbol:   method deleteJob(io.dapr.client.domain.DeleteJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[217,22] cannot find symbol
Error:    symbol:   method scheduleJob(io.dapr.client.domain.ScheduleJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error:  /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[224,22] cannot find symbol
Error:    symbol:   method deleteJob(io.dapr.client.domain.DeleteJobRequest)
Error:    location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient

@salaboy
Copy link
Collaborator Author

salaboy commented Dec 5, 2025

@cicoyle I was waiting for the pipelines to come back and show me those errors.. now that they run, fixes are pushed. Let's hope the pipelines behave now.

salaboy and others added 5 commits December 10, 2025 15:19
Signed-off-by: salaboy <[email protected]>
* Remove SDK docs due to migration to main Docs repo

Signed-off-by: Marc Duiker <[email protected]>

* Remove sed lines related to sdk docs

Signed-off-by: Marc Duiker <[email protected]>

---------

Signed-off-by: Marc Duiker <[email protected]>
Co-authored-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy salaboy requested a review from cicoyle December 10, 2025 14:20
Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salaboy
Copy link
Collaborator Author

salaboy commented Jan 5, 2026

I've retrigger the tests, because the failing test has nothing to do with Jobs

@salaboy
Copy link
Collaborator Author

salaboy commented Jan 5, 2026

all is good with this PR @dapr/maintainers-java-sdk please review and merge if this is done.

@salaboy salaboy requested a review from siri-varma January 5, 2026 11:32
@cicoyle cicoyle merged commit 001a4d2 into dapr:master Jan 5, 2026
16 of 22 checks passed
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.77%. Comparing base (d759c53) to head (8c9f7ef).
⚠️ Report is 246 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1602      +/-   ##
============================================
+ Coverage     76.91%   78.77%   +1.85%     
- Complexity     1592     2034     +442     
============================================
  Files           145      225      +80     
  Lines          4843     6115    +1272     
  Branches        562      669     +107     
============================================
+ Hits           3725     4817    +1092     
- Misses          821      956     +135     
- Partials        297      342      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Promote streaming Subcriptions and Job APIs from DaprPreviewClient to DaprClient

5 participants