Skip to content

Refactor mintMoment to use subedition #179

@jrkhan

Description

@jrkhan

Instructions

Refactor the existing minting method to be subedition aware, and remove the variant method added with the subedition feature branch.

Issue To Be Solved

Having a redundant minting method is confusing, and leaves a foot gun around in case one first mints moments with subeditions.

(Optional): Suggest A Solution

Steps to required deprecate/delete:

  1. Have NBA-API universally use the subedition minting method
  2. Refactor the initial minting method to be identical to the subedition minting method
  3. Have NBA-API universally use the initial minting method (that is now subedition aware)
  4. Remove the subedition minting method.

(Optional): Context

Flagged by @dete when reviewing the subedition change, and wanted to make sure it did not fall off the board.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions