Anthropic.ts saveState() ENOENT on first run when State/ directory missing

[chrisquorum]

Summary

saveState() in skills/PAIUpgrade/Tools/Anthropic.ts writes to State/last-check.json but doesn't create the parent directory if it doesn't exist. On first run after a fresh install (or after State/ is deleted), the initial write ENOENT's. The tool currently retries via fallback path and succeeds, but the initial error is noise and could mask other failures.

Repro

rm -rf ~/.claude/skills/PAIUpgrade/State/
bun ~/.claude/skills/PAIUpgrade/Tools/Anthropic.ts
# First save attempt: ENOENT on State/last-check.json
# Retry: succeeds

Observed during a PAIUpgrade audit run 2026-05-15.

Proposed fix

Add a mkdir -p equivalent before the first write in saveState():

import { mkdirSync } from 'fs';
import { dirname } from 'path';

// At the top of saveState(), before fs.writeFileSync(STATE_PATH, ...)
mkdirSync(dirname(STATE_PATH), { recursive: true });

One-line fix, idempotent, no behavior change when directory already exists.

Environment

• PAI 5.0.0
• skills/PAIUpgrade tool

[chrisquorum]

Verification pass — bug confirmed, with one nuance to the original framing

Re-checked this against current Tools/Anthropic.ts today after applying the same scrutiny to my sibling issue #1271 (which turned out to be a false alarm — closed). This one verifies as real.

What I confirmed

• STATE_DIR = join(SKILL_DIR, 'State') at line 83.
• STATE_FILE = join(STATE_DIR, 'last-check.json') at line 84.
• saveState() at lines 128-134:

  function saveState(state: State): void {
    try {
      writeFileSync(STATE_FILE, JSON.stringify(state, null, 2), 'utf-8');
    } catch (error) {
      console.error('❌ Failed to save state:', error);
    }
  }

• There is no mkdirSync(STATE_DIR, ...) anywhere in the file. grep -n "STATE_DIR\|mkdirSync.*State" Tools/Anthropic.ts returns only the constant declarations on lines 83-84.
• The same file uses the right pattern for LOG_DIR at lines 138-141 (if (!existsSync(LOG_DIR)) mkdirSync(LOG_DIR, { recursive: true })) — so the fix would just be applying the existing local pattern to STATE_DIR.

Nuance to my original framing

I wrote that "the tool currently retries and succeeds via fallback path." Re-reading the code, that's wrong — there is no retry or fallback. saveState() has a single try/catch that just logs ❌ Failed to save state: {error} and the state is silently lost for that run. So the failure mode is closer to "silent state loss on directory-missing" than "noisy error that eventually recovers." That makes the impact slightly worse than my original framing (and is more reason to apply the fix), though it's still Low severity overall.

On-disk evidence the bug may be biting silently

On a current install of mine, ~/.claude/skills/PAIUpgrade/State/ exists (created by an unrelated code path that writes github-trending.json), but last-check.json is not in it:

$ ls -la ~/.claude/skills/PAIUpgrade/State/
total 8
drwxr-xr-x@  3 user staff   96 May 15 23:39 .
drwxr-xr-x@ 10 user staff  320 May 15 23:38 ..
-rw-r--r--@  1 user staff  369 May 15 23:39 github-trending.json

That's consistent with saveState() having silently failed at some point — or never having succeeded — without surfacing to the user (the console.error in catch only shows up if the user happens to watch the stderr stream of the tool). The fix is harmless and worth applying even at Low priority.

Proposed fix (unchanged)

Add directory creation before the write:

import { mkdirSync } from 'fs';

function saveState(state: State): void {
  try {
    mkdirSync(STATE_DIR, { recursive: true });
    writeFileSync(STATE_FILE, JSON.stringify(state, null, 2), 'utf-8');
  } catch (error) {
    console.error('❌ Failed to save state:', error);
  }
}

Happy to open a PR if useful.

[danielmiessler]

Confirmed — this is still real in the current source (the skill is now called Upgrade, but saveState() still writes without creating State/ first, and the error gets swallowed). Your one-line mkdirSync fix is exactly right and is going in. Thanks for the precise repro.