Fix action failing when prevent-changes-to is empty (#3)

* Change README.md to test action

* Update README for function input changes

* Fix action failing when prevent-changes-to is empty

Author: danieljimeneznz

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [4.1.1] - 2021-08-28
+### Fixed
+- Action now succeeds when `prevent-changes-to` is omitted/empty
+
 ## [4.1.0] - 2021-08-26
 ### Changed
 - Update README.md for function input changes
@@ -49,7 +53,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
   - @actions/core     1.2.7  →   1.5.0
   - @actions/github   4.0.0  →   5.0.0
 
-[Unreleased]: https://github.com/syeutyu/validate-changed-files/compare/v4.1.0...HEAD
+[Unreleased]: https://github.com/syeutyu/validate-changed-files/compare/v4.1.1...HEAD
+[4.1.1]: https://github.com/syeutyu/validate-changed-files/compare/v4.1.0...v4.1.1
 [4.1.0]: https://github.com/syeutyu/validate-changed-files/compare/v4.0.1...v4.1.0
 [4.0.1]: https://github.com/syeutyu/validate-changed-files/compare/v4.0.0...v4.0.1
 [4.0.0]: https://github.com/syeutyu/validate-changed-files/compare/v3.0.3...v4.0.0

dist/index.js

@@ -7428,7 +7428,7 @@ async function main(
     (pattern) => !!changedFiles.find((file) => minimatch(file, pattern))
   );
 
-  const preventedFileChangedIncluded = preventFileChanges.every(
+  const preventedFileChangedIncluded = preventFileChanges.length > 0 && preventFileChanges.every(
     (pattern) => !!changedFiles.find((file) => minimatch(file, pattern))
   );
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "ensure-files-changed",
-  "version": "4.1.0",
+  "version": "4.1.1",
   "description": "Github action to validate changed files on a pull request",
   "main": "dist/index.js",
   "scripts": {

package.json

@@ -35,7 +35,7 @@ async function main(
     (pattern) => !!changedFiles.find((file) => minimatch(file, pattern))
   );
 
-  const preventedFileChangedIncluded = preventFileChanges.every(
+  const preventedFileChangedIncluded = preventFileChanges.length > 0 && preventFileChanges.every(
     (pattern) => !!changedFiles.find((file) => minimatch(file, pattern))
   );
 

src/index.js

@@ -71,6 +71,58 @@ describe("index.js", () => {
 
         expect(result).to.be.true;
       });
+
+      it("should succeed if required files changed but files prevented from changes is empty", async () => {
+        coreMock.expects("setOutput").withArgs("success", true).once();
+
+        const result = await main(
+          context,
+          {
+            rest: {
+              repos: {
+                compareCommitsWithBasehead: () => ({
+                  data: {
+                    files: [
+                      { filename: "package.json" },
+                      { filename: "README.md" },
+                    ],
+                  },
+                }),
+              },
+            },
+          },
+          ["package.json", "*.md"],
+          undefined
+        );
+
+        expect(result).to.be.true;
+      });
+
+      it("should succeed if files prevented from changing did not change and require file changes is empty", async () => {
+        coreMock.expects("setOutput").withArgs("success", true).once();
+
+        const result = await main(
+          context,
+          {
+            rest: {
+              repos: {
+                compareCommitsWithBasehead: () => ({
+                  data: {
+                    files: [
+                      { filename: "package.json" },
+                      { filename: "README.md" },
+                    ],
+                  },
+                }),
+              },
+            },
+          },
+          undefined,
+          ["LICENSE.md"],
+        );
+
+        expect(result).to.be.true;
+      });
     });
 
     describe("failure", () => {