Skip to content

Conversation

@LoHertel
Copy link

@LoHertel LoHertel commented Nov 6, 2025

Summary & Motivation

Even when Flower is disabled in the Helm values.yaml, the ConfigMap for Flower (configmap-env-flower.yaml) is still included in the Kubernetes deployment. This is unnecessary.

This PR adds a condition to exclude the Flower ConfigMap from the deployment, similar to how the ConfigMaps for the Daemon and Celery are handled.

How I Tested These Changes

Changelog

Include flower configmap only when flower deployment is enabled

@LoHertel
Copy link
Author

LoHertel commented Nov 8, 2025

Hi @alangenfeld, buildkite reported an error regarding Python 3.9. Asking you, because you have worked on dropping Python 3.9 support recently. Buildkite seems to still use a Python 3.9 image.

File "/root/.local/lib/python3.9/site-packages/buildkite_shared/step_builders/step_builder.py", line 1, in <module>
     from typing import TypeAlias, TypeGuard, Union
ImportError: cannot import name 'TypeAlias' from 'typing' (/usr/local/lib/python3.9/typing.py)

How can we resolve the failed buildkite run for this PR?

@alangenfeld
Copy link
Member

thanks for the heads-up, switched to a 3.12 image and kicked off this rebuild https://buildkite.com/dagster/unit-tests/builds/2341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants