-
Notifications
You must be signed in to change notification settings - Fork 30
Open
Labels
questionFlag this as a question for the next Cylc project meeting.Flag this as a question for the next Cylc project meeting.small
Milestone
Description
Currently any uncaught errors are handled here by presenting the alert snackbar in development mode only:
cylc-ui/src/layouts/Default.vue
Lines 88 to 92 in d010331
errorCaptured (error, vm, info) { | |
if (process.env.NODE_ENV !== 'production') { | |
store.dispatch('setAlert', new AlertModel(error, 'error')) | |
} | |
} |
If an uncaught error occurs in the production build, the only clues will be a console error that users won't see and some kind of broken functionality.
You can test this out by adding throw new Error('oops')
to the top of
cylc-ui/src/services/workflow.service.js
Line 214 in d010331
subscribe (componentOrView) { |
In fact there is an e2e test that ensures an alert is presented for this very scenario which only works because the e2e tests build the UI in development mode.
Metadata
Metadata
Assignees
Labels
questionFlag this as a question for the next Cylc project meeting.Flag this as a question for the next Cylc project meeting.small